garage/src/api/api_server.rs

use std::collections::HashMap;
use std::net::SocketAddr;
use std::sync::Arc;

use futures::future::Future;
use hyper::server::conn::AddrStream;
use hyper::service::{make_service_fn, service_fn};
use hyper::{Body, Method, Request, Response, Server};

use garage_util::error::Error as GarageError;

use garage_model::garage::Garage;

use crate::error::*;
use crate::signature::check_signature;

use crate::s3_copy::*;
use crate::s3_delete::*;
use crate::s3_get::*;
use crate::s3_list::*;
use crate::s3_put::*;

pub async fn run_api_server(
	garage: Arc<Garage>,
	shutdown_signal: impl Future<Output = ()>,
) -> Result<(), GarageError> {
	let addr = &garage.config.s3_api.api_bind_addr;

	let service = make_service_fn(|conn: &AddrStream| {
		let garage = garage.clone();
		let client_addr = conn.remote_addr();
		async move {
			Ok::<_, GarageError>(service_fn(move |req: Request<Body>| {
				let garage = garage.clone();
				handler(garage, req, client_addr)
			}))
		}
	});

	let server = Server::bind(&addr).serve(service);

	let graceful = server.with_graceful_shutdown(shutdown_signal);
	info!("API server listening on http://{}", addr);

	graceful.await?;
	Ok(())
}

async fn handler(
	garage: Arc<Garage>,
	req: Request<Body>,
	addr: SocketAddr,
) -> Result<Response<Body>, GarageError> {
	info!("{} {} {}", addr, req.method(), req.uri());
	debug!("{:?}", req);
	match handler_inner(garage, req).await {
		Ok(x) => {
			debug!("{} {:?}", x.status(), x.headers());
			Ok(x)
		}
		Err(e) => {
			let body: Body = Body::from(format!("{}\n", e));
			let mut http_error = Response::new(body);
			*http_error.status_mut() = e.http_status_code();
			warn!("Response: error {}, {}", e.http_status_code(), e);
			Ok(http_error)
		}
	}
}

async fn handler_inner(garage: Arc<Garage>, req: Request<Body>) -> Result<Response<Body>, Error> {
	let path = req.uri().path().to_string();
	let path = percent_encoding::percent_decode_str(&path).decode_utf8()?;

	let (bucket, key) = parse_bucket_key(&path)?;

	let (api_key, content_sha256) = check_signature(&garage, &req).await?;
	let allowed = match req.method() {
		&Method::HEAD | &Method::GET => api_key.allow_read(&bucket),
		_ => api_key.allow_write(&bucket),
	};
	if !allowed {
		return Err(Error::Forbidden(format!(
			"Operation is not allowed for this key."
		)));
	}

	let mut params = HashMap::new();
	if let Some(query) = req.uri().query() {
		let query_pairs = url::form_urlencoded::parse(query.as_bytes());
		for (key, val) in query_pairs {
			params.insert(key.to_lowercase(), val.to_string());
		}
	}

	if let Some(key) = key {
		match req.method() {
			&Method::HEAD => {
				// HeadObject query
				Ok(handle_head(garage, &bucket, &key).await?)
			}
			&Method::GET => {
				// GetObject query
				Ok(handle_get(garage, &req, &bucket, &key).await?)
			}
			&Method::PUT => {
				if params.contains_key(&"partnumber".to_string())
					&& params.contains_key(&"uploadid".to_string())
				{
					// UploadPart query
					let part_number = params.get("partnumber").unwrap();
					let upload_id = params.get("uploadid").unwrap();
					Ok(handle_put_part(
						garage,
						req,
						&bucket,
						&key,
						part_number,
						upload_id,
						content_sha256,
					)
					.await?)
				} else if req.headers().contains_key("x-amz-copy-source") {
					// CopyObject query
					let copy_source = req.headers().get("x-amz-copy-source").unwrap().to_str()?;
					let copy_source =
						percent_encoding::percent_decode_str(&copy_source).decode_utf8()?;
					let (source_bucket, source_key) = parse_bucket_key(&copy_source)?;
					if !api_key.allow_read(&source_bucket) {
						return Err(Error::Forbidden(format!(
							"Reading from bucket {} not allowed for this key",
							source_bucket
						)));
					}
					let source_key = source_key.ok_or_bad_request("No source key specified")?;
					Ok(handle_copy(garage, &bucket, &key, &source_bucket, &source_key).await?)
				} else {
					// PutObject query
					Ok(handle_put(garage, req, &bucket, &key, content_sha256).await?)
				}
			}
			&Method::DELETE => {
				if params.contains_key(&"uploadid".to_string()) {
					// AbortMultipartUpload query
					let upload_id = params.get("uploadid").unwrap();
					Ok(handle_abort_multipart_upload(garage, &bucket, &key, upload_id).await?)
				} else {
					// DeleteObject query
					Ok(handle_delete(garage, &bucket, &key).await?)
				}
			}
			&Method::POST => {
				if params.contains_key(&"uploads".to_string()) {
					// CreateMultipartUpload call
					Ok(handle_create_multipart_upload(garage, &req, &bucket, &key).await?)
				} else if params.contains_key(&"uploadid".to_string()) {
					// CompleteMultipartUpload call
					let upload_id = params.get("uploadid").unwrap();
					Ok(
						handle_complete_multipart_upload(garage, req, &bucket, &key, upload_id, content_sha256)
							.await?,
					)
				} else {
					Err(Error::BadRequest(format!(
						"Not a CreateMultipartUpload call, what is it?"
					)))
				}
			}
			_ => Err(Error::BadRequest(format!("Invalid method"))),
		}
	} else {
		match req.method() {
			&Method::PUT => {
				// CreateBucket
				// If we're here, the bucket already exists, so just answer ok
				debug!(
					"Body: {}",
					std::str::from_utf8(&hyper::body::to_bytes(req.into_body()).await?)
						.unwrap_or("<invalid utf8>")
				);
				let empty_body: Body = Body::from(vec![]);
				let response = Response::builder()
					.header("Location", format!("/{}", bucket))
					.body(empty_body)
					.unwrap();
				Ok(response)
			}
			&Method::HEAD => {
				// HeadBucket
				let empty_body: Body = Body::from(vec![]);
				let response = Response::builder().body(empty_body).unwrap();
				Ok(response)
			}
			&Method::DELETE => {
				// DeleteBucket query
				Err(Error::Forbidden(
					"Cannot delete buckets using S3 api, please talk to Garage directly".into(),
				))
			}
			&Method::GET => {
				// ListObjects or ListObjectsV2 query
				let q = parse_list_objects_query(bucket, &params)?;
				Ok(handle_list(garage, &q).await?)
			}
			&Method::POST => {
				if params.contains_key(&"delete".to_string()) {
					// DeleteObjects
					Ok(handle_delete_objects(garage, bucket, req, content_sha256).await?)
				} else {
					debug!(
						"Body: {}",
						std::str::from_utf8(&hyper::body::to_bytes(req.into_body()).await?)
							.unwrap_or("<invalid utf8>")
					);
					Err(Error::BadRequest(format!("Unsupported call")))
				}
			}
			_ => Err(Error::BadRequest(format!("Invalid method"))),
		}
	}
}

/// Extract the bucket name and the key name from an HTTP path
///
/// S3 internally manages only buckets and keys. This function splits
/// an HTTP path to get the corresponding bucket name and key.
fn parse_bucket_key(path: &str) -> Result<(&str, Option<&str>), Error> {
	let path = path.trim_start_matches('/');

	let (bucket, key) = match path.find('/') {
		Some(i) => {
			let key = &path[i + 1..];
			if key.len() > 0 {
				(&path[..i], Some(key))
			} else {
				(&path[..i], None)
			}
		}
		None => (path, None),
	};
	if bucket.len() == 0 {
		return Err(Error::BadRequest(format!("No bucket specified")));
	}
	Ok((bucket, key))
}

#[cfg(test)]
mod tests {
	use super::*;

	#[test]
	fn parse_bucket_containing_a_key() -> Result<(), Error> {
		let (bucket, key) = parse_bucket_key("/my_bucket/a/super/file.jpg")?;
		assert_eq!(bucket, "my_bucket");
		assert_eq!(key.expect("key must be set"), "a/super/file.jpg");
		Ok(())
	}

	#[test]
	fn parse_bucket_containing_no_key() -> Result<(), Error> {
		let (bucket, key) = parse_bucket_key("/my_bucket/")?;
		assert_eq!(bucket, "my_bucket");
		assert!(key.is_none());
		let (bucket, key) = parse_bucket_key("/my_bucket")?;
		assert_eq!(bucket, "my_bucket");
		assert!(key.is_none());
		Ok(())
	}

	#[test]
	fn parse_bucket_containing_no_bucket() {
		let parsed = parse_bucket_key("");
		assert!(parsed.is_err());
		let parsed = parse_bucket_key("/");
		assert!(parsed.is_err());
		let parsed = parse_bucket_key("////");
		assert!(parsed.is_err());
	}
}
Some basic S3 functionnality 2020-04-24 18:47:11 +00:00			`use std::collections::HashMap;`
More aggressive sync timings & improve other stuff 2020-04-19 17:59:59 +00:00			`use std::net::SocketAddr;`
Fix the Sync issue. Details: So the HTTP client future of Hyper is not Sync, thus the stream that read blocks wasn't either. However Hyper's default Body type requires a stream to be Sync for wrap_stream. Solution: reimplement a custom HTTP body type. 2020-04-10 20:01:48 +00:00			`use std::sync::Arc;`
Some more basic work 2020-04-06 17:55:39 +00:00
Fix the Sync issue. Details: So the HTTP client future of Hyper is not Sync, thus the stream that read blocks wasn't either. However Hyper's default Body type requires a stream to be Sync for wrap_stream. Solution: reimplement a custom HTTP body type. 2020-04-10 20:01:48 +00:00			`use futures::future::Future;`
Basic workflow for client PUT, next is do actual storage 2020-04-07 22:39:07 +00:00			`use hyper::server::conn::AddrStream;`
Fix the Sync issue. Details: So the HTTP client future of Hyper is not Sync, thus the stream that read blocks wasn't either. However Hyper's default Body type requires a stream to be Sync for wrap_stream. Solution: reimplement a custom HTTP body type. 2020-04-10 20:01:48 +00:00			`use hyper::service::{make_service_fn, service_fn};`
Some basic S3 functionnality 2020-04-24 18:47:11 +00:00			`use hyper::{Body, Method, Request, Response, Server};`
First commit: skeleton for something great 2020-04-05 21:33:42 +00:00
Refactor error management in API part 2020-11-08 14:04:30 +00:00			`use garage_util::error::Error as GarageError;`
Reorganize code 2020-04-23 17:05:46 +00:00
Rename garage_core to garage_model 2020-07-07 11:59:22 +00:00			`use garage_model::garage::Garage;`
Reorganize code 2020-04-23 17:05:46 +00:00
Refactor error management in API part 2020-11-08 14:04:30 +00:00			`use crate::error::*;`
Starting to be S3 compatible 2020-04-24 17:46:52 +00:00			`use crate::signature::check_signature;`
First commit: skeleton for something great 2020-04-05 21:33:42 +00:00
Work on API 2020-04-28 10:18:14 +00:00			`use crate::s3_copy::*;`
			`use crate::s3_delete::*;`
Implement multipart uploads 2020-04-26 20:39:32 +00:00			`use crate::s3_get::*;`
			`use crate::s3_list::*;`
			`use crate::s3_put::*;`
Fix the Sync issue. Details: So the HTTP client future of Hyper is not Sync, thus the stream that read blocks wasn't either. However Hyper's default Body type requires a stream to be Sync for wrap_stream. Solution: reimplement a custom HTTP body type. 2020-04-10 20:01:48 +00:00
			`pub async fn run_api_server(`
			`garage: Arc<Garage>,`
			`shutdown_signal: impl Future<Output = ()>,`
Refactor error management in API part 2020-11-08 14:04:30 +00:00			`) -> Result<(), GarageError> {`
Starting to be S3 compatible 2020-04-24 17:46:52 +00:00			`let addr = &garage.config.s3_api.api_bind_addr;`
First commit: skeleton for something great 2020-04-05 21:33:42 +00:00
Fix the Sync issue. Details: So the HTTP client future of Hyper is not Sync, thus the stream that read blocks wasn't either. However Hyper's default Body type requires a stream to be Sync for wrap_stream. Solution: reimplement a custom HTTP body type. 2020-04-10 20:01:48 +00:00			`let service = make_service_fn(\|conn: &AddrStream\| {`
Some work in actually storing things 2020-04-08 20:00:41 +00:00			`let garage = garage.clone();`
Basic workflow for client PUT, next is do actual storage 2020-04-07 22:39:07 +00:00			`let client_addr = conn.remote_addr();`
Some more basic work 2020-04-06 17:55:39 +00:00			`async move {`
Refactor error management in API part 2020-11-08 14:04:30 +00:00			`Ok::<_, GarageError>(service_fn(move \|req: Request<Body>\| {`
Some work in actually storing things 2020-04-08 20:00:41 +00:00			`let garage = garage.clone();`
			`handler(garage, req, client_addr)`
Some more basic work 2020-04-06 17:55:39 +00:00			`}))`
			`}`
			`});`
First commit: skeleton for something great 2020-04-05 21:33:42 +00:00
Fix the Sync issue. Details: So the HTTP client future of Hyper is not Sync, thus the stream that read blocks wasn't either. However Hyper's default Body type requires a stream to be Sync for wrap_stream. Solution: reimplement a custom HTTP body type. 2020-04-10 20:01:48 +00:00			`let server = Server::bind(&addr).serve(service);`
First commit: skeleton for something great 2020-04-05 21:33:42 +00:00
			`let graceful = server.with_graceful_shutdown(shutdown_signal);`
Pretty logging 2020-04-21 12:54:55 +00:00			`info!("API server listening on http://{}", addr);`
First commit: skeleton for something great 2020-04-05 21:33:42 +00:00
Background task runner that replaces tokio::spawn 2020-04-11 16:51:11 +00:00			`graceful.await?;`
			`Ok(())`
First commit: skeleton for something great 2020-04-05 21:33:42 +00:00			`}`
Basic workflow for client PUT, next is do actual storage 2020-04-07 22:39:07 +00:00
Fix the Sync issue. Details: So the HTTP client future of Hyper is not Sync, thus the stream that read blocks wasn't either. However Hyper's default Body type requires a stream to be Sync for wrap_stream. Solution: reimplement a custom HTTP body type. 2020-04-10 20:01:48 +00:00			`async fn handler(`
			`garage: Arc<Garage>,`
			`req: Request<Body>,`
			`addr: SocketAddr,`
Refactor error management in API part 2020-11-08 14:04:30 +00:00			`) -> Result<Response<Body>, GarageError> {`
Starting to be S3 compatible 2020-04-24 17:46:52 +00:00			`info!("{} {} {}", addr, req.method(), req.uri());`
			`debug!("{:?}", req);`
			`match handler_inner(garage, req).await {`
			`Ok(x) => {`
			`debug!("{} {:?}", x.status(), x.headers());`
			`Ok(x)`
			`}`
Basic workflow for client PUT, next is do actual storage 2020-04-07 22:39:07 +00:00			`Err(e) => {`
Update to Hyper 0.13.6 that accepts non-Sync streams in wrap_stream. Simplifies code and makes it possible to publish on crates.io 2020-07-07 15:15:53 +00:00			`let body: Body = Body::from(format!("{}\n", e));`
Fix the Sync issue. Details: So the HTTP client future of Hyper is not Sync, thus the stream that read blocks wasn't either. However Hyper's default Body type requires a stream to be Sync for wrap_stream. Solution: reimplement a custom HTTP body type. 2020-04-10 20:01:48 +00:00			`let mut http_error = Response::new(body);`
Some progress 2020-04-09 15:32:28 +00:00			`*http_error.status_mut() = e.http_status_code();`
Starting to be S3 compatible 2020-04-24 17:46:52 +00:00			`warn!("Response: error {}, {}", e.http_status_code(), e);`
Some progress 2020-04-09 15:32:28 +00:00			`Ok(http_error)`
Basic workflow for client PUT, next is do actual storage 2020-04-07 22:39:07 +00:00			`}`
			`}`
			`}`

Apply cargo fmt; add trace output when request signature is bad 2020-07-08 11:33:02 +00:00			`async fn handler_inner(garage: Arc<Garage>, req: Request<Body>) -> Result<Response<Body>, Error> {`
Starting to be S3 compatible 2020-04-24 17:46:52 +00:00			`let path = req.uri().path().to_string();`
Implement HTTP ranges in get 2020-05-04 13:09:23 +00:00			`let path = percent_encoding::percent_decode_str(&path).decode_utf8()?;`
Slightly improved S3 compatibility - ListBucket does not require any of the parameters (delimiter, prefix, max-keys, etc) - URLs are properly percent_decoded - PutObject and DeleteObject calls now answer correctly (empty body, version id in the x-amz-version-id: header) 2020-05-01 14:30:50 +00:00
			`let (bucket, key) = parse_bucket_key(&path)?;`
Starting to be S3 compatible 2020-04-24 17:46:52 +00:00
Validate content MD5 and SHA256 sums for PutObject and UploadPart 2020-07-15 13:31:13 +00:00			`let (api_key, content_sha256) = check_signature(&garage, &req).await?;`
Starting to be S3 compatible 2020-04-24 17:46:52 +00:00			`let allowed = match req.method() {`
			`&Method::HEAD \| &Method::GET => api_key.allow_read(&bucket),`
			`_ => api_key.allow_write(&bucket),`
			`};`
			`if !allowed {`
			`return Err(Error::Forbidden(format!(`
			`"Operation is not allowed for this key."`
			`)));`
			`}`

Implement multipart uploads 2020-04-26 20:39:32 +00:00			`let mut params = HashMap::new();`
			`if let Some(query) = req.uri().query() {`
			`let query_pairs = url::form_urlencoded::parse(query.as_bytes());`
			`for (key, val) in query_pairs {`
			`params.insert(key.to_lowercase(), val.to_string());`
			`}`
			`}`

Starting to be S3 compatible 2020-04-24 17:46:52 +00:00			`if let Some(key) = key {`
			`match req.method() {`
Implement multipart uploads 2020-04-26 20:39:32 +00:00			`&Method::HEAD => {`
			`// HeadObject query`
			`Ok(handle_head(garage, &bucket, &key).await?)`
			`}`
			`&Method::GET => {`
			`// GetObject query`
Implement HTTP ranges in get 2020-05-04 13:09:23 +00:00			`Ok(handle_get(garage, &req, &bucket, &key).await?)`
Implement multipart uploads 2020-04-26 20:39:32 +00:00			`}`
Starting to be S3 compatible 2020-04-24 17:46:52 +00:00			`&Method::PUT => {`
Work on API 2020-04-28 10:18:14 +00:00			`if params.contains_key(&"partnumber".to_string())`
			`&& params.contains_key(&"uploadid".to_string())`
Implement multipart uploads 2020-04-26 20:39:32 +00:00			`{`
Abort multipart upload 2020-04-26 20:46:21 +00:00			`// UploadPart query`
Implement multipart uploads 2020-04-26 20:39:32 +00:00			`let part_number = params.get("partnumber").unwrap();`
			`let upload_id = params.get("uploadid").unwrap();`
Validate content MD5 and SHA256 sums for PutObject and UploadPart 2020-07-15 13:31:13 +00:00			`Ok(handle_put_part(`
			`garage,`
			`req,`
			`&bucket,`
			`&key,`
			`part_number,`
			`upload_id,`
			`content_sha256,`
			`)`
			`.await?)`
Work on API 2020-04-28 10:18:14 +00:00			`} else if req.headers().contains_key("x-amz-copy-source") {`
			`// CopyObject query`
			`let copy_source = req.headers().get("x-amz-copy-source").unwrap().to_str()?;`
Implement HTTP ranges in get 2020-05-04 13:09:23 +00:00			`let copy_source =`
			`percent_encoding::percent_decode_str(&copy_source).decode_utf8()?;`
Slightly improved S3 compatibility - ListBucket does not require any of the parameters (delimiter, prefix, max-keys, etc) - URLs are properly percent_decoded - PutObject and DeleteObject calls now answer correctly (empty body, version id in the x-amz-version-id: header) 2020-05-01 14:30:50 +00:00			`let (source_bucket, source_key) = parse_bucket_key(&copy_source)?;`
Work on API 2020-04-28 10:18:14 +00:00			`if !api_key.allow_read(&source_bucket) {`
			`return Err(Error::Forbidden(format!(`
			`"Reading from bucket {} not allowed for this key",`
			`source_bucket`
			`)));`
			`}`
Refactor error management in API part 2020-11-08 14:04:30 +00:00			`let source_key = source_key.ok_or_bad_request("No source key specified")?;`
Work on API 2020-04-28 10:18:14 +00:00			`Ok(handle_copy(garage, &bucket, &key, &source_bucket, &source_key).await?)`
Implement multipart uploads 2020-04-26 20:39:32 +00:00			`} else {`
			`// PutObject query`
Validate content MD5 and SHA256 sums for PutObject and UploadPart 2020-07-15 13:31:13 +00:00			`Ok(handle_put(garage, req, &bucket, &key, content_sha256).await?)`
Implement multipart uploads 2020-04-26 20:39:32 +00:00			`}`
Starting to be S3 compatible 2020-04-24 17:46:52 +00:00			`}`
			`&Method::DELETE => {`
Abort multipart upload 2020-04-26 20:46:21 +00:00			`if params.contains_key(&"uploadid".to_string()) {`
			`// AbortMultipartUpload query`
			`let upload_id = params.get("uploadid").unwrap();`
			`Ok(handle_abort_multipart_upload(garage, &bucket, &key, upload_id).await?)`
			`} else {`
			`// DeleteObject query`
Implement DeleteObjects 2020-05-01 15:52:35 +00:00			`Ok(handle_delete(garage, &bucket, &key).await?)`
Abort multipart upload 2020-04-26 20:46:21 +00:00			`}`
Starting to be S3 compatible 2020-04-24 17:46:52 +00:00			`}`
Implement multipart uploads 2020-04-26 20:39:32 +00:00			`&Method::POST => {`
			`if params.contains_key(&"uploads".to_string()) {`
			`// CreateMultipartUpload call`
			`Ok(handle_create_multipart_upload(garage, &req, &bucket, &key).await?)`
			`} else if params.contains_key(&"uploadid".to_string()) {`
Abort multipart upload 2020-04-26 20:46:21 +00:00			`// CompleteMultipartUpload call`
Implement multipart uploads 2020-04-26 20:39:32 +00:00			`let upload_id = params.get("uploadid").unwrap();`
Work on API 2020-04-28 10:18:14 +00:00			`Ok(`
Add verification of part numbers in CompleteMultipartUpload (WIP #30) 2021-02-19 23:13:07 +00:00			`handle_complete_multipart_upload(garage, req, &bucket, &key, upload_id, content_sha256)`
Work on API 2020-04-28 10:18:14 +00:00			`.await?,`
			`)`
Implement multipart uploads 2020-04-26 20:39:32 +00:00			`} else {`
			`Err(Error::BadRequest(format!(`
			`"Not a CreateMultipartUpload call, what is it?"`
			`)))`
			`}`
			`}`
Starting to be S3 compatible 2020-04-24 17:46:52 +00:00			`_ => Err(Error::BadRequest(format!("Invalid method"))),`
Background task runner that replaces tokio::spawn 2020-04-11 16:51:11 +00:00			`}`
Starting to be S3 compatible 2020-04-24 17:46:52 +00:00			`} else {`
Some basic S3 functionnality 2020-04-24 18:47:11 +00:00			`match req.method() {`
Slightly improved S3 compatibility - ListBucket does not require any of the parameters (delimiter, prefix, max-keys, etc) - URLs are properly percent_decoded - PutObject and DeleteObject calls now answer correctly (empty body, version id in the x-amz-version-id: header) 2020-05-01 14:30:50 +00:00			`&Method::PUT => {`
			`// CreateBucket`
S3 compatibility: fix bucket listing and HEAD and PUT on bucket 2020-04-26 16:22:33 +00:00			`// If we're here, the bucket already exists, so just answer ok`
Fix S3 ListObjects result and replace println!s by debug!s 2021-01-16 15:05:54 +00:00			`debug!(`
Slightly improved S3 compatibility - ListBucket does not require any of the parameters (delimiter, prefix, max-keys, etc) - URLs are properly percent_decoded - PutObject and DeleteObject calls now answer correctly (empty body, version id in the x-amz-version-id: header) 2020-05-01 14:30:50 +00:00			`"Body: {}",`
			`std::str::from_utf8(&hyper::body::to_bytes(req.into_body()).await?)`
			`.unwrap_or("<invalid utf8>")`
			`);`
Update to Hyper 0.13.6 that accepts non-Sync streams in wrap_stream. Simplifies code and makes it possible to publish on crates.io 2020-07-07 15:15:53 +00:00			`let empty_body: Body = Body::from(vec![]);`
S3 compatibility: fix bucket listing and HEAD and PUT on bucket 2020-04-26 16:22:33 +00:00			`let response = Response::builder()`
			`.header("Location", format!("/{}", bucket))`
			`.body(empty_body)`
			`.unwrap();`
			`Ok(response)`
Prepare for multipart uploads 2020-04-26 18:55:13 +00:00			`}`
Slightly improved S3 compatibility - ListBucket does not require any of the parameters (delimiter, prefix, max-keys, etc) - URLs are properly percent_decoded - PutObject and DeleteObject calls now answer correctly (empty body, version id in the x-amz-version-id: header) 2020-05-01 14:30:50 +00:00			`&Method::HEAD => {`
			`// HeadBucket`
Update to Hyper 0.13.6 that accepts non-Sync streams in wrap_stream. Simplifies code and makes it possible to publish on crates.io 2020-07-07 15:15:53 +00:00			`let empty_body: Body = Body::from(vec![]);`
Slightly improved S3 compatibility - ListBucket does not require any of the parameters (delimiter, prefix, max-keys, etc) - URLs are properly percent_decoded - PutObject and DeleteObject calls now answer correctly (empty body, version id in the x-amz-version-id: header) 2020-05-01 14:30:50 +00:00			`let response = Response::builder().body(empty_body).unwrap();`
			`Ok(response)`
			`}`
Implement multipart uploads 2020-04-26 20:39:32 +00:00			`&Method::DELETE => {`
			`// DeleteBucket query`
			`Err(Error::Forbidden(`
			`"Cannot delete buckets using S3 api, please talk to Garage directly".into(),`
			`))`
			`}`
Some basic S3 functionnality 2020-04-24 18:47:11 +00:00			`&Method::GET => {`
Add compatibility list 2021-02-19 18:10:23 +00:00			`// ListObjects or ListObjectsV2 query`
Implement ListObjectsV2 2021-02-19 15:44:06 +00:00			`let q = parse_list_objects_query(bucket, &params)?;`
			`Ok(handle_list(garage, &q).await?)`
Do not insert deletion marker if there is no object to delete 2020-04-21 14:33:12 +00:00			`}`
Implement HTTP ranges in get 2020-05-04 13:09:23 +00:00			`&Method::POST => {`
			`if params.contains_key(&"delete".to_string()) {`
			`// DeleteObjects`
Add verification of part numbers in CompleteMultipartUpload (WIP #30) 2021-02-19 23:13:07 +00:00			`Ok(handle_delete_objects(garage, bucket, req, content_sha256).await?)`
Implement HTTP ranges in get 2020-05-04 13:09:23 +00:00			`} else {`
Fix S3 ListObjects result and replace println!s by debug!s 2021-01-16 15:05:54 +00:00			`debug!(`
Implement HTTP ranges in get 2020-05-04 13:09:23 +00:00			`"Body: {}",`
			`std::str::from_utf8(&hyper::body::to_bytes(req.into_body()).await?)`
			`.unwrap_or("<invalid utf8>")`
			`);`
			`Err(Error::BadRequest(format!("Unsupported call")))`
			`}`
			`}`
			`_ => Err(Error::BadRequest(format!("Invalid method"))),`
Why is it not Sync?? 2020-04-09 21:45:07 +00:00			`}`
			`}`
			`}`
Work on API 2020-04-28 10:18:14 +00:00
Add a test for parse_bucket_key 2020-11-07 12:53:32 +00:00			`/// Extract the bucket name and the key name from an HTTP path`
			`///`
			`/// S3 internally manages only buckets and keys. This function splits`
			`/// an HTTP path to get the corresponding bucket name and key.`
Work on API 2020-04-28 10:18:14 +00:00			`fn parse_bucket_key(path: &str) -> Result<(&str, Option<&str>), Error> {`
Compatibility fixes 2020-04-28 10:35:04 +00:00			`let path = path.trim_start_matches('/');`
Work on API 2020-04-28 10:18:14 +00:00
Modif parse_bucket_key to fail when bucket is "" 2020-11-08 12:39:44 +00:00			`let (bucket, key) = match path.find('/') {`
Slightly improved S3 compatibility - ListBucket does not require any of the parameters (delimiter, prefix, max-keys, etc) - URLs are properly percent_decoded - PutObject and DeleteObject calls now answer correctly (empty body, version id in the x-amz-version-id: header) 2020-05-01 14:30:50 +00:00			`Some(i) => {`
			`let key = &path[i + 1..];`
			`if key.len() > 0 {`
Modif parse_bucket_key to fail when bucket is "" 2020-11-08 12:39:44 +00:00			`(&path[..i], Some(key))`
Slightly improved S3 compatibility - ListBucket does not require any of the parameters (delimiter, prefix, max-keys, etc) - URLs are properly percent_decoded - PutObject and DeleteObject calls now answer correctly (empty body, version id in the x-amz-version-id: header) 2020-05-01 14:30:50 +00:00			`} else {`
Modif parse_bucket_key to fail when bucket is "" 2020-11-08 12:39:44 +00:00			`(&path[..i], None)`
Slightly improved S3 compatibility - ListBucket does not require any of the parameters (delimiter, prefix, max-keys, etc) - URLs are properly percent_decoded - PutObject and DeleteObject calls now answer correctly (empty body, version id in the x-amz-version-id: header) 2020-05-01 14:30:50 +00:00			`}`
			`}`
Modif parse_bucket_key to fail when bucket is "" 2020-11-08 12:39:44 +00:00			`None => (path, None),`
			`};`
			`if bucket.len() == 0 {`
			`return Err(Error::BadRequest(format!("No bucket specified")));`
Work on API 2020-04-28 10:18:14 +00:00			`}`
Modif parse_bucket_key to fail when bucket is "" 2020-11-08 12:39:44 +00:00			`Ok((bucket, key))`
Work on API 2020-04-28 10:18:14 +00:00			`}`
Add a test for parse_bucket_key 2020-11-07 12:53:32 +00:00
			`#[cfg(test)]`
			`mod tests {`
			`use super::*;`

			`#[test]`
Add a second test 2020-11-07 14:34:53 +00:00			`fn parse_bucket_containing_a_key() -> Result<(), Error> {`
Fix formatting 2020-11-07 12:59:30 +00:00			`let (bucket, key) = parse_bucket_key("/my_bucket/a/super/file.jpg")?;`
Add a test for parse_bucket_key 2020-11-07 12:53:32 +00:00			`assert_eq!(bucket, "my_bucket");`
Fix formatting 2020-11-07 12:59:30 +00:00			`assert_eq!(key.expect("key must be set"), "a/super/file.jpg");`
Add a test for parse_bucket_key 2020-11-07 12:53:32 +00:00			`Ok(())`
Modif parse_bucket_key to fail when bucket is "" 2020-11-08 12:39:44 +00:00			`}`
Add a second test 2020-11-07 14:34:53 +00:00
			`#[test]`
			`fn parse_bucket_containing_no_key() -> Result<(), Error> {`
			`let (bucket, key) = parse_bucket_key("/my_bucket/")?;`
			`assert_eq!(bucket, "my_bucket");`
			`assert!(key.is_none());`
			`let (bucket, key) = parse_bucket_key("/my_bucket")?;`
			`assert_eq!(bucket, "my_bucket");`
			`assert!(key.is_none());`
			`Ok(())`
Add a test for parse_bucket_key 2020-11-07 12:53:32 +00:00			`}`
Modif parse_bucket_key to fail when bucket is "" 2020-11-08 12:39:44 +00:00
			`#[test]`
			`fn parse_bucket_containing_no_bucket() {`
			`let parsed = parse_bucket_key("");`
			`assert!(parsed.is_err());`
			`let parsed = parse_bucket_key("/");`
			`assert!(parsed.is_err());`
			`let parsed = parse_bucket_key("////");`
			`assert!(parsed.is_err());`
			`}`
Add a test for parse_bucket_key 2020-11-07 12:53:32 +00:00			`}`