Simplify

plugins/base/routes.go

@@ -181,7 +181,7 @@ func newIMAPBaseRenderData(ctx *alps.Context,
 
 	var categorized CategorizedMailboxes
 
-	for i, _ := range mailboxes {
+	for i := range mailboxes {
 		// Populate unseen & active states
 		if active != nil && mailboxes[i].Name == active.Name {
 			mailboxes[i].Unseen = int(active.Unseen)
@@ -403,6 +403,9 @@ type MessageRenderData struct {
 
 func handleGetPart(ctx *alps.Context, raw bool) error {
 	_, uid, err := parseMboxAndUid(ctx.Param("mbox"), ctx.Param("uid"))
+	if err != nil {
+		return err
+	}
 	ibase, err := newIMAPBaseRenderData(ctx, alps.NewBaseRenderData(ctx))
 	if err != nil {
 		return err
@@ -468,9 +471,8 @@ func handleGetPart(ctx *alps.Context, raw bool) error {
 
 		if len(partPath) == 0 {
 			return part.WriteTo(ctx.Response())
-		} else {
-			return ctx.Stream(http.StatusOK, mimeType, part.Body)
 		}
+		return ctx.Stream(http.StatusOK, mimeType, part.Body)
 	}
 
 	view, err := viewMessagePart(ctx, msg, part)

plugins/base/template.go

@@ -19,9 +19,7 @@ var templateFuncs = template.FuncMap{
 	"tuple": func(values ...interface{}) []interface{} {
 		return values
 	},
-	"pathescape": func(s string) string {
-		return url.PathEscape(s)
-	},
+	"pathescape": url.PathEscape,
 	"formatdate": func(t time.Time) string {
 		return t.Format("Mon Jan 02 15:04")
 	},
@@ -47,9 +45,7 @@ var templateFuncs = template.FuncMap{
 			return true
 		}
 	},
-	"join": func(l []string, sep string) string {
-		return strings.Join(l, sep)
-	},
+	"join": strings.Join,
 	"formatinputdate": func(t time.Time) string {
 		if t.IsZero() {
 			return ""

plugins/caldav/routes.go

@@ -134,7 +134,7 @@ func registerRoutes(p *alps.GoPlugin, u *url.URL) {
 		var dates [7 * 6]time.Time
 		initialDate := start.UTC()
 		initialDate = initialDate.AddDate(0, 0, -int(initialDate.Weekday()))
-		for i := 0; i < len(dates); i += 1 {
+		for i := 0; i < len(dates); i++ {
 			dates[i] = initialDate
 			initialDate = initialDate.AddDate(0, 0, 1)
 		}