Deuxfleurs/alps
24
1
Fork 0
Code Issues Pull requests 1 Projects Releases Wiki Activity

gracefully fail when no messages are selected for deletion or moving

Browse source
This commit is contained in:
Alex McGrath 2022-05-07 09:17:12 +01:00 committed by Simon Ser
parent f4523b51af
commit 7cb145748a
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
plugins/base/routes.go
View file

@ -1024,6 +1024,11 @@ func handleMove(ctx *alps.Context) error {
return echo.NewHTTPError(http.StatusBadRequest, err) return echo.NewHTTPError(http.StatusBadRequest, err)
} }
if len(uids) == 0 {
ctx.Session.PutNotice("No messages selected.")
return ctx.Redirect(http.StatusFound, fmt.Sprintf("/mailbox/%v", url.PathEscape(mboxName)))
}
to := formOrQueryParam(ctx, "to") to := formOrQueryParam(ctx, "to")
if to == "" { if to == "" {
return echo.NewHTTPError(http.StatusBadRequest, "missing 'to' form parameter") return echo.NewHTTPError(http.StatusBadRequest, "missing 'to' form parameter")
@ -1071,6 +1076,11 @@ func handleDelete(ctx *alps.Context) error {
return echo.NewHTTPError(http.StatusBadRequest, err) return echo.NewHTTPError(http.StatusBadRequest, err)
} }
if len(uids) == 0 {
ctx.Session.PutNotice("No messages selected.")
return ctx.Redirect(http.StatusFound, fmt.Sprintf("/mailbox/%v", url.PathEscape(mboxName)))
}
err = ctx.Session.DoIMAP(func(c *imapclient.Client) error { err = ctx.Session.DoIMAP(func(c *imapclient.Client) error {
if err := ensureMailboxSelected(c, mboxName); err != nil { if err := ensureMailboxSelected(c, mboxName); err != nil {
return err return err