delay write to consul when stun fails #26

New issue

Closed

opened 2025-02-17 19:20:12 +00:00 by trinity-1686a · 1 comment

trinity-1686a commented

2025-02-17 19:20:12 +00:00

Owner

we've had 2 incidents in less than a week related to diplonat failing to get an IP (due to a faulty stun server)
to be more resilient, diplonat shouldn't write null ip into consul, but likely leave the existing entry alone, and eventually delete the entry when it's really getting old

we've had 2 incidents in less than a week related to diplonat failing to get an IP (due to a faulty stun server) to be more resilient, diplonat shouldn't write `null` ip into consul, but likely leave the existing entry alone, and eventually delete the entry when it's really getting old

trinity-1686a commented

2025-02-17 22:32:48 +00:00

Author

Owner

this already exists:

 /// If autodiscovery returns None but an address was obtained less than
 /// this number of seconds ago (here 15 minutes), we keep that address
 /// in the Consul db instead of insterting a None.
 const PERSIST_SOME_RESULT_DURATION_SECS: u64 = 900;