Exterminate cosmetic warnings #6

Open
opened 2021-08-16 10:01:02 +00:00 by adrien · 0 comments
Owner

There are 5 warnings left after PR #5, all cosmetic e.g.:

  • "variant tcp_port should have an upper camel case name"
  • "structure field Tags should have a snake case name"

This is easily solved using Serde's rename_all attribute (see Serde Lexpr's Enum use-case for an example).

I can remove these warnings myself, but I'll wait until we merge PR #5.

There are 5 warnings left after [PR #5](https://git.deuxfleurs.fr/Deuxfleurs/diplonat/pulls/5), all cosmetic e.g.: * "variant `tcp_port` should have an upper camel case name" * "structure field `Tags` should have a snake case name" This is easily solved using [Serde's `rename_all` attribute](https://serde.rs/variant-attrs.html#rename_all) (see [Serde Lexpr's Enum use-case](https://docs.rs/serde-lexpr/0.1.2/serde_lexpr/index.html#enums) for an example). I can remove these warnings myself, but I'll wait until we merge [PR #5](https://git.deuxfleurs.fr/Deuxfleurs/diplonat/pulls/5).
adrien added the
enhancement
label 2021-08-16 10:10:39 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/diplonat#6
No description provided.