diff --git a/src/api/admin/api.rs b/src/api/admin/api.rs index 6176ac3a..7a903810 100644 --- a/src/api/admin/api.rs +++ b/src/api/admin/api.rs @@ -10,7 +10,6 @@ use serde::{Deserialize, Serialize}; use garage_rpc::*; use garage_model::garage::Garage; -use garage_util::error::Error as GarageError; use crate::admin::api_server::{AdminRpc, AdminRpcResponse}; use crate::admin::error::Error; @@ -104,21 +103,6 @@ pub struct MultiResponse { pub error: HashMap, } -impl MultiResponse { - pub fn into_single_response(self) -> Result { - if let Some((_, e)) = self.error.into_iter().next() { - return Err(GarageError::Message(e)); - } - if self.success.len() != 1 { - return Err(GarageError::Message(format!( - "{} responses returned, expected 1", - self.success.len() - ))); - } - Ok(self.success.into_iter().next().unwrap().1) - } -} - // ********************************************** // Special endpoints // diff --git a/src/garage/cli_v2/mod.rs b/src/garage/cli_v2/mod.rs index 0f0b3b34..f1f1163a 100644 --- a/src/garage/cli_v2/mod.rs +++ b/src/garage/cli_v2/mod.rs @@ -16,7 +16,7 @@ use garage_rpc::*; use garage_api::admin::api::*; use garage_api::admin::api_server::{AdminRpc as ProxyRpc, AdminRpcResponse as ProxyRpcResponse}; -use garage_api::admin::RequestHandler as AdminApiEndpoint; +use garage_api::admin::RequestHandler; use crate::admin::*; use crate::cli as cli_v1; @@ -74,11 +74,11 @@ impl Cli { } } - pub async fn api_request(&self, req: T) -> Result<::Response, Error> + pub async fn api_request(&self, req: T) -> Result<::Response, Error> where - T: AdminApiEndpoint, + T: RequestHandler, AdminApiRequest: From, - ::Response: TryFrom, + ::Response: TryFrom, { let req = AdminApiRequest::from(req); let req_name = req.name(); @@ -88,7 +88,7 @@ impl Cli { .await?? { ProxyRpcResponse::ProxyApiOkResponse(resp) => { - ::Response::try_from(resp).map_err(|_| { + ::Response::try_from(resp).map_err(|_| { Error::Message(format!("{} returned unexpected response", req_name)) }) } @@ -103,4 +103,32 @@ impl Cli { m => Err(Error::unexpected_rpc_message(m)), } } + + pub async fn local_api_request( + &self, + req: T, + ) -> Result<::Response, Error> + where + T: RequestHandler, + MultiRequest: RequestHandler::Response>>, + AdminApiRequest: From>, + as RequestHandler>::Response: TryFrom, + { + let req = MultiRequest { + node: hex::encode(self.rpc_host), + body: req, + }; + let resp = self.api_request(req).await?; + + if let Some((_, e)) = resp.error.into_iter().next() { + return Err(Error::Message(e)); + } + if resp.success.len() != 1 { + return Err(Error::Message(format!( + "{} responses returned, expected 1", + resp.success.len() + ))); + } + Ok(resp.success.into_iter().next().unwrap().1) + } } diff --git a/src/garage/cli_v2/worker.rs b/src/garage/cli_v2/worker.rs index 05cfdb27..991b9f06 100644 --- a/src/garage/cli_v2/worker.rs +++ b/src/garage/cli_v2/worker.rs @@ -27,15 +27,11 @@ impl Cli { pub async fn cmd_list_workers(&self, opt: WorkerListOpt) -> Result<(), Error> { let mut list = self - .api_request(ListWorkersRequest { - node: hex::encode(self.rpc_host), - body: LocalListWorkersRequest { - busy_only: opt.busy, - error_only: opt.errors, - }, + .local_api_request(LocalListWorkersRequest { + busy_only: opt.busy, + error_only: opt.errors, }) .await? - .into_single_response()? .0; list.sort_by_key(|info| { @@ -90,12 +86,8 @@ impl Cli { pub async fn cmd_worker_info(&self, tid: usize) -> Result<(), Error> { let info = self - .api_request(GetWorkerInfoRequest { - node: hex::encode(self.rpc_host), - body: LocalGetWorkerInfoRequest { id: tid as u64 }, - }) + .local_api_request(LocalGetWorkerInfoRequest { id: tid as u64 }) .await? - .into_single_response()? .0; let mut table = vec![];