Implement ListParts #194
No reviewers
Labels
No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#194
Loading…
Reference in New Issue
No description provided.
Delete Branch "features/list-parts"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
479c1596cf
to071caa57ae
071caa57ae
to5d2e40f398
fa80e00807
to1beca7c30e
WIP: Implement ListPartsto Implement ListPartsLGTM
@ -236,0 +266,4 @@
garage
.object_table
.get(&query.bucket_id, &query.key)
.map_err(Error::from),
I think we can remove
map_err(Error::from)
here and below as it is implied in the?
operator.@ -236,0 +288,4 @@
.iter()
.map(|part| s3_xml::PartItem {
etag: s3_xml::Value(format!("\"{}\"", part.etag)),
last_modified: s3_xml::Value(msec_to_rfc3339(0)),
Rather than 0 I think here we should put the timestamp of the object version
@ -297,0 +308,4 @@
key,
upload_id,
part_number_marker: part_number_marker.map(|p| min(10000, max(1, p))),
max_parts: max_parts.map(|p| min(1000, max(1, p))).unwrap_or(1000),
prefere using
clamp
, min(max(..)..) is unclear and very much subject to inverting bounds.1beca7c30e
to94f0e7c135