Implement exponential backoff for resync retries #252

Merged
lx merged 1 commits from bug/resync-exponential-backoff into feature/opentelemetry 2022-03-14 10:47:40 +00:00
Owner
No description provided.
lx force-pushed bug/resync-exponential-backoff from 16fad698b0 to beed72f128 2022-02-25 20:04:51 +00:00 Compare
lx force-pushed bug/resync-exponential-backoff from e18d4fd811 to 68b2693cd4 2022-03-01 11:02:15 +00:00 Compare
quentin added the
Performance
label 2022-03-03 13:51:30 +00:00
quentin approved these changes 2022-03-04 09:50:07 +00:00
quentin left a comment
Owner

LGTM

LGTM
@ -40,3 +40,3 @@
pub const BACKGROUND_WORKERS: u64 = 1;
pub const BACKGROUND_TRANQUILITY: u32 = 3;
pub const BACKGROUND_TRANQUILITY: u32 = 2;
Owner

Just curiosity, but is there a reason why you decreased it?

Just curiosity, but is there a reason why you decreased it?
@ -563,0 +575,4 @@
if let Some(ec) = self.resync_errors.get(hash.as_slice())? {
let ec = ErrorCounter::decode(ec);
if now < ec.next_try() {
// if next retry after an error is not yet,
Owner

I know understand that your correctness PR depends on this one.

I know understand that your correctness PR depends on this one.
lx added
Bug
and removed
Performance
labels 2022-03-09 16:20:59 +00:00
lx added 29 commits 2022-03-14 10:41:29 +00:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
2a3afcaf65
Test WinSCP
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
c00b2c9948
Functional tests for admin commands
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
9d44127245
add support for kubernetes service discovery
This commit adds support to discover garage instances running in
kubernetes.

Once enabled by setting `kubernetes_namespace` and
`kubernetes_service_name` garage will create a Custom Resources
`garagenodes.deuxfleurs.fr` with nodes public key as the resource name.
and IP and Port information as spec in the namespace configured by
`kubernetes_namespace`.

For discovering nodes the resources are filtered with the optionally set
`kubernetes_service_name` which sets a label
`garage.deuxfleurs.fr/service` on the resources.

This allows to separate multiple garage deployments in a single
namespace.

the `kubernetes_skip_crd` variable allows to disable the creation of the
CRD by garage itself. The user must deploy this manually.
e349af13a7
Update dependencies and add admin module with metrics
- Global dependencies updated in Cargo.lock
- New module created in src/admin to host:
  - the (future) admin REST API
  - the metric collection
- add configuration block

No metrics implemented yet
continuous-integration/drone/push Build was killed Details
continuous-integration/drone/pr Build was killed Details
9b2b531f4d
Make admin server optional
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
bfb4353df5
Update Grafana dashboard
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
fe62d01b7e
Implement exponential backoff for resync retries
lx merged commit fe62d01b7e into feature/opentelemetry 2022-03-14 10:47:40 +00:00
Sign in to join this conversation.
No description provided.