Deuxfleurs
/
garage
43
37
Fork 55
Code Issues 69 Pull Requests 4 Releases 29 Wiki Activity

Compile kuberetes-discovery only when release=true #276

Manually merged
lx merged 2 commits from ci/feature-flag into kube-feature-flag 2022-03-24 13:25:01 +00:00
Conversation 0 Commits 2 Files Changed 9 +244 -331
quentin commented 2022-03-24 09:31:48 +00:00
Owner
Copy Link

Tested locally by setting kubernetes_namespace=test in the config file and launching the build:

  • a debug build once run will output WARN: kubernetes-discovery feature is missing
  • a release build once run will NOT output the previous warning

a promoted build is running here: https://drone.deuxfleurs.fr/Deuxfleurs/garage/1433

Tested locally by setting `kubernetes_namespace=test` in the config file and launching the build: - a debug build once run will output `WARN: kubernetes-discovery feature is missing` - a release build once run will NOT output the previous warning a promoted build is running here: https://drone.deuxfleurs.fr/Deuxfleurs/garage/1433
quentin added 1 commit 2022-03-24 09:31:50 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone Build is failing Details
62a45747a5 Compile kuberetes-discovery only when release=true
lx manually merged commit 055c94450c into kube-feature-flag 2022-03-24 13:25:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#276
No description provided.
Delete Branch "ci/feature-flag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?