Deuxfleurs/tricot
16
3
Fork 3
Code Issues 4 Pull requests 1 Projects Releases Wiki Activity

reverse proxy: also add tag-based headers for redirections #17

Merged
Armael merged 1 commit from Armael/tricot:headers_for_redirects into main 2024-12-01 15:31:14 +00:00
Conversation 0 Commits 1 Files changed 1 +2 -2
Armael commented 2024-12-01 14:53:29 +00:00
Owner
Copy link

This PR makes tricot-add-header tags also applied to "redirect" responses (3xx responses), where before it only applied to "success" responses (2xx).

The motivation comes from cryptpad, where, it seems:

This PR makes `tricot-add-header` tags also applied to "redirect" responses (3xx responses), where before it only applied to "success" responses (2xx). The motivation comes from cryptpad, where, it seems: - we need tricot to add CORS-related headers (https://git.deuxfleurs.fr/Deuxfleurs/nixcfg/src/branch/main/cluster/prod/app/cryptpad/deploy/cryptpad.hcl#L66) - cryptpad sends 304 responses for which we need to set CORS headers, something that is not possible currently, it seems.
Armael added 1 commit 2024-12-01 14:53:29 +00:00
reverse proxy: also add tag-based headers for redirections
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
e89f3b67bd
maximilien requested review from maximilien 2024-12-01 15:06:03 +00:00
Armael merged commit 2a679f97b6 into main 2024-12-01 15:31:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
maximilien
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/tricot#17
No description provided.
Delete branch "Armael/tricot:headers_for_redirects"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?