garage-sdk/garage-admin-sdk-generator
5
0
Fork 1
Code Issues Pull requests 1 Projects Releases 1 Wiki Activity

SDKs need regeneration #1

New issue
Closed
opened 2023-01-31 02:04:43 +00:00 by fivebats · 2 comments
fivebats commented 2023-01-31 02:04:43 +00:00
Copy link

The api file was changed as a fix to garage/#476, so it seems like these SDKs should be regenerated.

I'm happy to do it and make a pull request if you like.

The api file was changed as a fix to garage/#476, so it seems like these SDKs should be regenerated. I'm happy to do it and make a pull request if you like.
quentin commented 2023-01-31 08:18:17 +00:00
Owner
Copy link

Sorry for the delay and thanks for your tracking of this issue.
I did not forget my promise, I was just more busy than expected...

I upgraded the SDKs, only the Golang one lead to change in code.
The diff is here: c965fe7f7d

I did not take the time to test it, can you confirm that it works and solve your problem?

Thanks in advance.

For the next patches, I will see if we want to automate the regeneration of the SDK if we want to better document the steps involved to regen it so people can easily provide a PR so I do not become a bottleneck for changes ^^

Sorry for the delay and thanks for your tracking of this issue. I did not forget my promise, I was just more busy than expected... I upgraded the SDKs, only the Golang one lead to change in code. The diff is here: https://git.deuxfleurs.fr/garage-sdk/garage-admin-sdk-golang/commit/c965fe7f7dc93b9b9a65ec4015c4e7ede0f6121b I did not take the time to test it, can you confirm that it works and solve your problem? Thanks in advance. For the next patches, I will see if we want to automate the regeneration of the SDK if we want to better document the steps involved to regen it so people can easily provide a PR so I do not become a bottleneck for changes ^^
fivebats commented 2023-02-01 00:41:01 +00:00
Author
Copy link

The regenerated go SDK fixes my issue. Thanks!

The regenerated go SDK fixes my issue. Thanks!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
api-v0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: garage-sdk/garage-admin-sdk-generator#1
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?