Alex lx
lx pushed to master at Deuxfleurs/garage 2021-01-15 17:52:20 +00:00
lx pushed tag 0.1.0b to Deuxfleurs/garage 2021-01-15 17:25:56 +00:00
lx pushed tag 0.1.0 to Deuxfleurs/garage 2021-01-15 17:25:55 +00:00
lx pushed tag 0.1.1 to Deuxfleurs/garage 2021-01-15 16:55:19 +00:00
lx pushed to master at Deuxfleurs/garage 2021-01-15 16:55:12 +00:00
lx pushed tag 0.1.1 to Deuxfleurs/garage 2021-01-15 16:50:40 +00:00
lx pushed to master at Deuxfleurs/garage 2021-01-15 16:49:52 +00:00
lx merged pull request Deuxfleurs/garage#7 2021-01-15 16:49:51 +00:00
Support website publishing
lx closed issue Deuxfleurs/garage#6 2021-01-15 16:49:51 +00:00
Allow anonymous read access to buckets to enable website hosting
lx pushed to feature/website at Deuxfleurs/garage 2021-01-15 16:49:21 +00:00
lx commented on pull request Deuxfleurs/garage#7 2021-01-15 12:07:58 +00:00
Support website publishing

Thank you. I understand better now. Let's keep it.

lx commented on pull request Deuxfleurs/garage#7 2021-01-13 21:21:23 +00:00
Support website publishing

Probably put unreachable!() in else branch ? Because get_existing_bucket does not return a bucket that is deleted. (I think so, this should be checked)

lx commented on pull request Deuxfleurs/garage#7 2021-01-13 21:21:23 +00:00
Support website publishing

Why break the convention that bucket name = domain name of the hosted website ? This gives more flexibility as we can host sites on diffferent tld/sld. If a website needs to move, we will copy files to the new bucket, it shouldn't be too costly (we don't expect to store TBs of data for a website...)

lx commented on pull request Deuxfleurs/garage#7 2021-01-13 21:21:23 +00:00
Support website publishing

roxmltree, rustls, webpki, httpdate and maybe some others can probably be removed

lx commented on pull request Deuxfleurs/garage#7 2021-01-13 21:21:23 +00:00
Support website publishing

are all variants used? (try commenting them to find out)

lx commented on pull request Deuxfleurs/garage#7 2021-01-13 21:21:23 +00:00
Support website publishing

this case is unreachable!() thanks to the previous if

lx commented on pull request Deuxfleurs/garage#7 2021-01-13 21:21:23 +00:00
Support website publishing

Rewrite as only two cases:

lx commented on pull request Deuxfleurs/garage#7 2021-01-13 21:21:23 +00:00
Support website publishing

NO!! expect makes us crash (panic) if the condition is not verified, this is not acceptable (we don't want to assume that authority is well formed, maybe hyper checks it for us but maybe not and we don't want to take risks)

lx suggested changes for Deuxfleurs/garage#7 2021-01-13 21:21:23 +00:00
Support website publishing

There are a few minor changes to make.

lx commented on pull request Deuxfleurs/garage#7 2021-01-13 21:21:22 +00:00
Support website publishing

update_bucket_key ?