Alex lx
lx commented on pull request Deuxfleurs/garage#751 2024-03-03 14:26:18 +00:00
add request context helper

Does this patch apply easily to the main (v0.9) branch ? Because if it does it would be nice to have it there, to minimize divergence between the two.

lx commented on pull request Deuxfleurs/garage#750 2024-03-03 14:21:51 +00:00
ReplicationMode -> ConsistencyMode+ReplicationFactor

The same can be achieved with #[derive(Serialize, Deserialize)] + #[serde(transparent)]

lx commented on pull request Deuxfleurs/garage#750 2024-03-03 14:21:51 +00:00
ReplicationMode -> ConsistencyMode+ReplicationFactor

In degraded mode, we will have write_quorum = replication_mode, but that doesn't seem right?

lx commented on pull request Deuxfleurs/garage#750 2024-03-03 14:21:51 +00:00
ReplicationMode -> ConsistencyMode+ReplicationFactor

Does this work for values written in lowercase? Because the enum variants start with a capital letter.

lx commented on pull request Deuxfleurs/garage#750 2024-03-03 14:21:51 +00:00
ReplicationMode -> ConsistencyMode+ReplicationFactor

We don't need this function anymore, right?

lx suggested changes for Deuxfleurs/garage#750 2024-03-03 14:21:51 +00:00
ReplicationMode -> ConsistencyMode+ReplicationFactor

Some minor things to fix here and there.

lx commented on pull request Deuxfleurs/garage#750 2024-03-03 14:21:50 +00:00
ReplicationMode -> ConsistencyMode+ReplicationFactor

Did you mean write_quorum instead of read_quorum ?

lx commented on pull request Deuxfleurs/garage#750 2024-03-03 14:21:50 +00:00
ReplicationMode -> ConsistencyMode+ReplicationFactor

Is the default value (empty string) parsed the same as "consistent" ?

lx commented on pull request Deuxfleurs/garage#750 2024-03-03 14:21:50 +00:00
ReplicationMode -> ConsistencyMode+ReplicationFactor

We probably want a migration path, or at least a safeguard, for people that don't update their config files and continue using the old replication_mode variable.

lx commented on pull request Deuxfleurs/garage#750 2024-03-03 14:21:50 +00:00
ReplicationMode -> ConsistencyMode+ReplicationFactor

Did you mean write_quorum instead of read_quorum?

lx merged pull request Deuxfleurs/garage#749 2024-03-03 13:51:39 +00:00
doc: fix typo in connect/backup.md
lx pushed to main at Deuxfleurs/garage 2024-03-03 13:51:39 +00:00
c4de471de1 Merge pull request 'doc: fix typo in connect/backup.md' (#749) from Armael/garage:doc-typo into main
16e17375c5 doc: fix typo in connect/backup.md
Compare 2 commits »
lx pushed to main at Deuxfleurs/nixcfg 2024-03-01 17:11:44 +00:00
62bd80a346 garage: update to v0.9.2 final
lx deleted branch rel-0.9.2 from Deuxfleurs/garage 2024-03-01 16:20:30 +00:00
lx merged pull request Deuxfleurs/garage#747 2024-03-01 16:20:29 +00:00
Bump version to v0.9.2
lx pushed to main at Deuxfleurs/garage 2024-03-01 16:20:29 +00:00
95ab36aae7 Merge pull request 'Bump version to v0.9.2' (#747) from rel-0.9.2 into main
6a7623e90d [rel-0.9.2] Bump version to v0.9.2
Compare 2 commits »
lx pushed tag v0.9.2 to Deuxfleurs/garage 2024-03-01 16:19:26 +00:00
lx pushed to rel-0.9.2 at Deuxfleurs/garage 2024-03-01 15:54:51 +00:00
6a7623e90d [rel-0.9.2] Bump version to v0.9.2
lx created pull request Deuxfleurs/garage#747 2024-03-01 14:14:57 +00:00
Bump version to v0.9.2
lx created branch rel-0.9.2 in Deuxfleurs/garage 2024-03-01 14:14:22 +00:00