I'm surprised that an enum with no variants causes a compilation issue, I thought it would just mean "this code is unreachable" for the compiler. I think it's a known practice to use an empty enum…
This is no longer specific to the output db, so maybe rename it db_open
?
Similarly, comment should be updated to say that it applies to either input or output db
LGTM, we can merge this part first. Just two minor changes since the db parameters are no longer specific to the output db
Hi @networkException, I have not forgotten this PR, it's on my radar for inclusion at some point in the next few months. Sorry for the wait.
I was wondering if there might be a "gotcha" in S3, for example: multi-character delimiters being accepted but only the last character actually being taken into account. To make sure that the full…
I have added the Engine enum into db module on assumption it is generic enough and may be useful to have it there. If it is not correct, let me know and I will move it to cli::convert_db…
is it plausible that running scrub could clear those errors?
In theory, scrub is completely unrelated. If the number of errors went down, I think it's more because Garage finally realized…