quentin/hugo-wasm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1
hugo-wasm/tpl/internal/go_templates
History
Bjørn Erik Pedersen 929808190f tpl/partials: Fix recently introduced deadlock in partials cache 
The change in lock logic for `partialCached` in  0927cf739f was naive as it didn't consider cached partials calling other cached partials.

This changeset may look on the large side for this particular issue, but it pulls in part of a working branch, introducing `context.Context` in the template execution.

Note that the context is only partially implemented in this PR, but the upcoming use cases will, as one example, include having access to the top "dot" (e.g. `Page`) all the way down into partials and shortcodes etc.

The earlier benchmarks rerun against master:

```bash
name              old time/op    new time/op    delta
IncludeCached-10    13.6ms ± 2%    13.8ms ± 1%    ~     (p=0.343 n=4+4)

name              old alloc/op   new alloc/op   delta
IncludeCached-10    5.30MB ± 0%    5.35MB ± 0%  +0.96%  (p=0.029 n=4+4)

name              old allocs/op  new allocs/op  delta
IncludeCached-10     74.7k ± 0%     75.3k ± 0%  +0.77%  (p=0.029 n=4+4)
```

Fixes #9519
2022-02-17 18:47:36 +01:00
..
cfg tpl/internal: Synch Go templates fork with Go 1.16dev 2021-02-18 14:11:48 +01:00
fmtsort tpl/internal: Synch Go templates fork with Go 1.16dev 2021-02-18 14:11:48 +01:00
htmltemplate Add breaking tests for "map read and map write in templates" 2021-02-18 14:11:48 +01:00
testenv Pull in latest Go template source 2021-02-18 14:11:48 +01:00
texttemplate tpl/partials: Fix recently introduced deadlock in partials cache 2022-02-17 18:47:36 +01:00