forked from Deuxfleurs/garage
Alex
b44d3fc796
- [x] Design interface - [x] Implement Sled backend - [x] Re-implement the SledCountedTree hack ~~on Sled backend~~ on all backends (i.e. over the abstraction) - [x] Convert Garage code to use generic interface - [x] Proof-read converted Garage code - [ ] Test everything well - [x] Implement sqlite backend - [x] Implement LMDB backend - [ ] (Implement Persy backend?) - [ ] (Implement other backends? (like RocksDB, ...)) - [x] Implement backend choice in config file and garage server module - [x] Add CLI for converting between DB formats - Exploit the new interface to put more things in transactions - [x] `.updated()` trigger on Garage tables Fix #284 **Bugs** - [x] When exporting sqlite, trees iterate empty?? - [x] LMDB doesn't work **Known issues for various back-ends** - Sled: - Eats all my RAM and also all my disk space - `.len()` has to traverse the whole table - Is actually quite slow on some operations - And is actually pretty bad code... - Sqlite: - Requires a lock to be taken on all operations. The lock is also taken when iterating on a table with `.iter()`, and the lock isn't released until the iterator is dropped. This means that we must be VERY carefull to not do anything else inside a `.iter()` loop or else we will have a deadlock! Most such cases have been eliminated from the Garage codebase, but there might still be some that remain. If your Garage-over-Sqlite seems to hang/freeze, this is the reason. - (adapter uses a bunch of unsafe code) - Heed (LMDB): - Not suited for 32-bit machines as it has to map the whole DB in memory. - (adpater uses a tiny bit of unsafe code) **My recommendation:** avoid 32-bit machines and use LMDB as much as possible. **Converting databases** is actually quite easy. For example from Sled to LMDB: ```bash cd src/db cargo run --features cli --bin convert -- -i path/to/garage/meta/db -a sled -o path/to/garage/meta/db.lmdb -b lmdb ``` Then, just add this to your `config.toml`: ```toml db_engine = "lmdb" ``` Co-authored-by: Alex Auvolat <alex@adnab.me> Reviewed-on: Deuxfleurs/garage#322 Co-authored-by: Alex <alex@adnab.me> Co-committed-by: Alex <alex@adnab.me>
191 lines
4.6 KiB
Rust
191 lines
4.6 KiB
Rust
use std::collections::HashMap;
|
|
use std::net::SocketAddr;
|
|
use std::sync::Arc;
|
|
|
|
use hyper::{Body, Request, Response, StatusCode};
|
|
use serde::{Deserialize, Serialize};
|
|
|
|
use garage_util::crdt::*;
|
|
use garage_util::data::*;
|
|
|
|
use garage_rpc::layout::*;
|
|
|
|
use garage_model::garage::Garage;
|
|
|
|
use crate::admin::error::*;
|
|
use crate::helpers::{json_ok_response, parse_json_body};
|
|
|
|
pub async fn handle_get_cluster_status(garage: &Arc<Garage>) -> Result<Response<Body>, Error> {
|
|
let res = GetClusterStatusResponse {
|
|
node: hex::encode(garage.system.id),
|
|
garage_version: garage.system.garage_version(),
|
|
db_engine: garage.db.engine(),
|
|
known_nodes: garage
|
|
.system
|
|
.get_known_nodes()
|
|
.into_iter()
|
|
.map(|i| {
|
|
(
|
|
hex::encode(i.id),
|
|
KnownNodeResp {
|
|
addr: i.addr,
|
|
is_up: i.is_up,
|
|
last_seen_secs_ago: i.last_seen_secs_ago,
|
|
hostname: i.status.hostname,
|
|
},
|
|
)
|
|
})
|
|
.collect(),
|
|
layout: get_cluster_layout(garage),
|
|
};
|
|
|
|
Ok(json_ok_response(&res)?)
|
|
}
|
|
|
|
pub async fn handle_connect_cluster_nodes(
|
|
garage: &Arc<Garage>,
|
|
req: Request<Body>,
|
|
) -> Result<Response<Body>, Error> {
|
|
let req = parse_json_body::<Vec<String>>(req).await?;
|
|
|
|
let res = futures::future::join_all(req.iter().map(|node| garage.system.connect(node)))
|
|
.await
|
|
.into_iter()
|
|
.map(|r| match r {
|
|
Ok(()) => ConnectClusterNodesResponse {
|
|
success: true,
|
|
error: None,
|
|
},
|
|
Err(e) => ConnectClusterNodesResponse {
|
|
success: false,
|
|
error: Some(format!("{}", e)),
|
|
},
|
|
})
|
|
.collect::<Vec<_>>();
|
|
|
|
Ok(json_ok_response(&res)?)
|
|
}
|
|
|
|
pub async fn handle_get_cluster_layout(garage: &Arc<Garage>) -> Result<Response<Body>, Error> {
|
|
let res = get_cluster_layout(garage);
|
|
|
|
Ok(json_ok_response(&res)?)
|
|
}
|
|
|
|
fn get_cluster_layout(garage: &Arc<Garage>) -> GetClusterLayoutResponse {
|
|
let layout = garage.system.get_cluster_layout();
|
|
|
|
GetClusterLayoutResponse {
|
|
version: layout.version,
|
|
roles: layout
|
|
.roles
|
|
.items()
|
|
.iter()
|
|
.filter(|(_, _, v)| v.0.is_some())
|
|
.map(|(k, _, v)| (hex::encode(k), v.0.clone()))
|
|
.collect(),
|
|
staged_role_changes: layout
|
|
.staging
|
|
.items()
|
|
.iter()
|
|
.filter(|(k, _, v)| layout.roles.get(k) != Some(v))
|
|
.map(|(k, _, v)| (hex::encode(k), v.0.clone()))
|
|
.collect(),
|
|
}
|
|
}
|
|
|
|
#[derive(Serialize)]
|
|
#[serde(rename_all = "camelCase")]
|
|
struct GetClusterStatusResponse {
|
|
node: String,
|
|
garage_version: &'static str,
|
|
db_engine: String,
|
|
known_nodes: HashMap<String, KnownNodeResp>,
|
|
layout: GetClusterLayoutResponse,
|
|
}
|
|
|
|
#[derive(Serialize)]
|
|
struct ConnectClusterNodesResponse {
|
|
success: bool,
|
|
error: Option<String>,
|
|
}
|
|
|
|
#[derive(Serialize)]
|
|
#[serde(rename_all = "camelCase")]
|
|
struct GetClusterLayoutResponse {
|
|
version: u64,
|
|
roles: HashMap<String, Option<NodeRole>>,
|
|
staged_role_changes: HashMap<String, Option<NodeRole>>,
|
|
}
|
|
|
|
#[derive(Serialize)]
|
|
struct KnownNodeResp {
|
|
addr: SocketAddr,
|
|
is_up: bool,
|
|
last_seen_secs_ago: Option<u64>,
|
|
hostname: String,
|
|
}
|
|
|
|
pub async fn handle_update_cluster_layout(
|
|
garage: &Arc<Garage>,
|
|
req: Request<Body>,
|
|
) -> Result<Response<Body>, Error> {
|
|
let updates = parse_json_body::<UpdateClusterLayoutRequest>(req).await?;
|
|
|
|
let mut layout = garage.system.get_cluster_layout();
|
|
|
|
let mut roles = layout.roles.clone();
|
|
roles.merge(&layout.staging);
|
|
|
|
for (node, role) in updates {
|
|
let node = hex::decode(node).ok_or_bad_request("Invalid node identifier")?;
|
|
let node = Uuid::try_from(&node).ok_or_bad_request("Invalid node identifier")?;
|
|
|
|
layout
|
|
.staging
|
|
.merge(&roles.update_mutator(node, NodeRoleV(role)));
|
|
}
|
|
|
|
garage.system.update_cluster_layout(&layout).await?;
|
|
|
|
Ok(Response::builder()
|
|
.status(StatusCode::OK)
|
|
.body(Body::empty())?)
|
|
}
|
|
|
|
pub async fn handle_apply_cluster_layout(
|
|
garage: &Arc<Garage>,
|
|
req: Request<Body>,
|
|
) -> Result<Response<Body>, Error> {
|
|
let param = parse_json_body::<ApplyRevertLayoutRequest>(req).await?;
|
|
|
|
let layout = garage.system.get_cluster_layout();
|
|
let layout = layout.apply_staged_changes(Some(param.version))?;
|
|
garage.system.update_cluster_layout(&layout).await?;
|
|
|
|
Ok(Response::builder()
|
|
.status(StatusCode::OK)
|
|
.body(Body::empty())?)
|
|
}
|
|
|
|
pub async fn handle_revert_cluster_layout(
|
|
garage: &Arc<Garage>,
|
|
req: Request<Body>,
|
|
) -> Result<Response<Body>, Error> {
|
|
let param = parse_json_body::<ApplyRevertLayoutRequest>(req).await?;
|
|
|
|
let layout = garage.system.get_cluster_layout();
|
|
let layout = layout.revert_staged_changes(Some(param.version))?;
|
|
garage.system.update_cluster_layout(&layout).await?;
|
|
|
|
Ok(Response::builder()
|
|
.status(StatusCode::OK)
|
|
.body(Body::empty())?)
|
|
}
|
|
|
|
type UpdateClusterLayoutRequest = HashMap<String, Option<NodeRole>>;
|
|
|
|
#[derive(Deserialize)]
|
|
struct ApplyRevertLayoutRequest {
|
|
version: u64,
|
|
}
|