Upstreaming patches written for Garage's benchmark #1

Merged
trinity-1686a merged 7 commits from quentin/mknet:improvements into main 2021-12-13 13:09:28 +00:00
Owner
  • I use /usr/bin/env as /bin/env does not work on debian
  • I added a README to help new users
  • I updated Garage's bash script to fix a bug when the 2 hierarchies (dc/host and host alone) are not present at the same time
  • I added a setup.py script to easily install mknet through pip
  • I added a python script to deploy minio
  • I added a SIZE environment variable to simplify my scripts
  • I updated the usage text of the command line to the name of the installed tool

I did some cleaning on my script so I need to test them before removing the WIP: on the PR to check that I did not put new bugs

- I use `/usr/bin/env` as `/bin/env` does not work on debian - I added a README to help new users - I updated Garage's bash script to fix a bug when the 2 hierarchies (dc/host and host alone) are not present at the same time - I added a setup.py script to easily install mknet through pip - I added a python script to deploy minio - I added a `SIZE` environment variable to simplify my scripts - I updated the *usage* text of the command line to the name of the installed tool *I did some cleaning on my script so I need to test them before removing the WIP: on the PR to check that I did not put new bugs*
quentin added 4 commits 2021-12-08 15:38:41 +00:00

you should rename "SIZE" to something more meaningfull like "SERVER_COUNT", it took me a bit of time to understand what it was used for.
Otherwise, lgtm! I'll merge when you say it's ready

you should rename "SIZE" to something more meaningfull like "SERVER_COUNT", it took me a bit of time to understand what it was used for. Otherwise, lgtm! I'll merge when you say it's ready
quentin added 1 commit 2021-12-08 17:07:04 +00:00
quentin added 1 commit 2021-12-13 09:53:59 +00:00
Author
Owner

you should rename "SIZE" to something more meaningfull like "SERVER_COUNT", it took me a bit of time to understand what it was used for.

done!

>you should rename "SIZE" to something more meaningfull like "SERVER_COUNT", it took me a bit of time to understand what it was used for. done!
quentin changed title from WIP: Upstreaming patches written for Garage's benchmark to Upstreaming patches written for Garage's benchmark 2021-12-13 09:54:41 +00:00
quentin force-pushed improvements from 690b650b4a to 9719f4b294 2021-12-13 09:56:34 +00:00 Compare
quentin added 1 commit 2021-12-13 09:57:42 +00:00
trinity-1686a merged commit 5a8be6fc73 into main 2021-12-13 13:09:28 +00:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/mknet#1
No description provided.