As explained above, I feel like a default implementation should be what we want in most case. Of 5 implementations of this trait, only 2 actually use an empty updated, so being explicit about it…
hum, it might double-count pings, as it count once in rpc_clients, and once in this file in ping_nodes
it's sorted in recalculate_hash. Actually the node list is short, so sorting it is pretty much free
Ok I've read s3 doc on multi-part upload and I hate it. Next comment appear to be false too, it's offset in part, not in the whole file
I would not necessarily call it bad practice. It conveyed to me that "doing nothing" is a good default behavior, and while doing nothing might be a valid behavior, I think wanting to do nothing…
I understand resync both get missing blocks and remove unnecessary blocks. My problem is that if I understand the code correctly, when the counter go down from 1 to 0, the value for new_rc is Some(0)…
It prevents use from other crates, but not from this one. It does not break anything, but does prevent using those traits in web in the future, for instance ????
