garage/src/api/s3_put.rs

656 lines
17 KiB
Rust
Raw Normal View History

2020-07-08 15:34:37 +00:00
use std::collections::{BTreeMap, VecDeque};
2020-04-26 20:39:32 +00:00
use std::fmt::Write;
2020-04-24 18:47:11 +00:00
use std::sync::Arc;
use futures::stream::*;
2020-04-26 20:39:32 +00:00
use hyper::{Body, Request, Response};
2020-11-22 10:04:33 +00:00
use md5::{digest::generic_array::*, Digest as Md5Digest, Md5};
use sha2::{Digest as Sha256Digest, Sha256};
2020-04-24 18:47:11 +00:00
2020-04-28 10:18:14 +00:00
use garage_table::*;
2020-04-24 18:47:11 +00:00
use garage_util::data::*;
2020-11-08 14:04:30 +00:00
use garage_util::error::Error as GarageError;
2020-04-24 18:47:11 +00:00
2020-07-07 11:59:22 +00:00
use garage_model::block::INLINE_THRESHOLD;
use garage_model::block_ref_table::*;
use garage_model::garage::Garage;
use garage_model::object_table::*;
use garage_model::version_table::*;
2020-04-24 18:47:11 +00:00
2020-04-28 10:18:14 +00:00
use crate::encoding::*;
2021-02-23 17:46:25 +00:00
use crate::error::*;
use crate::signature::verify_signed_content;
2020-04-26 20:39:32 +00:00
2020-04-24 18:47:11 +00:00
pub async fn handle_put(
garage: Arc<Garage>,
2020-04-26 20:39:32 +00:00
req: Request<Body>,
2020-04-24 18:47:11 +00:00
bucket: &str,
key: &str,
content_sha256: Option<Hash>,
) -> Result<Response<Body>, Error> {
// Generate identity of new version
2020-04-24 18:47:11 +00:00
let version_uuid = gen_uuid();
let version_timestamp = now_msec();
// Retrieve interesting headers from request
2020-07-09 15:04:43 +00:00
let headers = get_headers(&req)?;
debug!("Object headers: {:?}", headers);
let content_md5 = match req.headers().get("content-md5") {
Some(x) => Some(x.to_str()?.to_string()),
None => None,
};
2020-07-08 15:33:24 +00:00
// Parse body of uploaded file
2020-04-26 20:39:32 +00:00
let body = req.into_body();
2020-04-24 18:47:11 +00:00
let mut chunker = BodyChunker::new(body, garage.config.block_size);
2020-11-11 15:12:42 +00:00
let first_block = chunker.next().await?.unwrap_or(vec![]);
2020-04-24 18:47:11 +00:00
// If body is small enough, store it directly in the object table
// as "inline data". We can then return immediately.
2020-04-24 18:47:11 +00:00
if first_block.len() < INLINE_THRESHOLD {
let mut md5sum = Md5::new();
md5sum.update(&first_block[..]);
let data_md5sum = md5sum.finalize();
let data_md5sum_hex = hex::encode(data_md5sum);
let data_sha256sum = sha256sum(&first_block[..]);
2020-11-22 10:14:46 +00:00
ensure_checksum_matches(
data_md5sum.as_slice(),
data_sha256sum,
2020-11-22 10:14:46 +00:00
content_md5.as_deref(),
content_sha256,
)?;
let object_version = ObjectVersion {
uuid: version_uuid,
timestamp: version_timestamp,
state: ObjectVersionState::Complete(ObjectVersionData::Inline(
ObjectVersionMeta {
headers,
size: first_block.len() as u64,
etag: data_md5sum_hex.clone(),
},
first_block,
)),
};
2020-04-24 18:47:11 +00:00
let object = Object::new(bucket.into(), key.into(), vec![object_version]);
garage.object_table.insert(&object).await?;
return Ok(put_response(version_uuid, data_md5sum_hex));
2020-04-24 18:47:11 +00:00
}
// Write version identifier in object table so that we have a trace
// that we are uploading something
let mut object_version = ObjectVersion {
uuid: version_uuid,
timestamp: now_msec(),
state: ObjectVersionState::Uploading(headers.clone()),
};
2020-04-24 18:47:11 +00:00
let object = Object::new(bucket.into(), key.into(), vec![object_version.clone()]);
garage.object_table.insert(&object).await?;
// Initialize corresponding entry in version table
let version = Version::new(version_uuid, bucket.into(), key.into(), false);
let first_block_hash = blake2sum(&first_block[..]);
// Transfer data and verify checksum
let tx_result = read_and_put_blocks(
2020-04-28 10:18:14 +00:00
&garage,
&version,
2020-04-28 10:18:14 +00:00
1,
first_block,
first_block_hash,
&mut chunker,
)
.await
.and_then(|(total_size, data_md5sum, data_sha256sum)| {
ensure_checksum_matches(
data_md5sum.as_slice(),
data_sha256sum,
content_md5.as_deref(),
content_sha256,
)
.map(|()| (total_size, data_md5sum))
});
// If something went wrong, clean up
let (total_size, md5sum_arr) = match tx_result {
Ok(rv) => rv,
Err(e) => {
// Mark object as aborted, this will free the blocks further down
object_version.state = ObjectVersionState::Aborted;
let object = Object::new(bucket.into(), key.into(), vec![object_version.clone()]);
garage.object_table.insert(&object).await?;
return Err(e);
}
};
2020-11-22 10:04:33 +00:00
// Save final object state, marked as Complete
2020-11-22 10:04:33 +00:00
let md5sum_hex = hex::encode(md5sum_arr);
object_version.state = ObjectVersionState::Complete(ObjectVersionData::FirstBlock(
ObjectVersionMeta {
headers,
size: total_size,
etag: md5sum_hex.clone(),
},
first_block_hash,
));
let object = Object::new(bucket.into(), key.into(), vec![object_version]);
garage.object_table.insert(&object).await?;
Ok(put_response(version_uuid, md5sum_hex))
}
/// Validate MD5 sum against content-md5 header
/// and sha256sum against signed content-sha256
fn ensure_checksum_matches(
data_md5sum: &[u8],
data_sha256sum: garage_util::data::FixedBytes32,
2020-11-22 10:04:33 +00:00
content_md5: Option<&str>,
content_sha256: Option<garage_util::data::FixedBytes32>,
) -> Result<(), Error> {
if let Some(expected_sha256) = content_sha256 {
if expected_sha256 != data_sha256sum {
2020-11-08 14:04:30 +00:00
return Err(Error::BadRequest(format!(
"Unable to validate x-amz-content-sha256"
)));
2020-07-15 13:41:49 +00:00
} else {
trace!("Successfully validated x-amz-content-sha256");
}
}
if let Some(expected_md5) = content_md5 {
if expected_md5.trim_matches('"') != base64::encode(data_md5sum) {
2020-11-08 14:04:30 +00:00
return Err(Error::BadRequest(format!("Unable to validate content-md5")));
2020-07-15 13:41:49 +00:00
} else {
trace!("Successfully validated content-md5");
}
}
2020-11-22 10:04:33 +00:00
Ok(())
2020-04-26 20:39:32 +00:00
}
async fn read_and_put_blocks(
garage: &Arc<Garage>,
version: &Version,
2020-04-26 20:39:32 +00:00
part_number: u64,
first_block: Vec<u8>,
first_block_hash: Hash,
chunker: &mut BodyChunker,
2020-11-22 10:04:33 +00:00
) -> Result<(u64, GenericArray<u8, typenum::U16>, Hash), Error> {
let mut md5hasher = Md5::new();
let mut sha256hasher = Sha256::new();
md5hasher.update(&first_block[..]);
sha256hasher.input(&first_block[..]);
2020-04-24 18:47:11 +00:00
let mut next_offset = first_block.len();
2020-04-28 10:18:14 +00:00
let mut put_curr_version_block = put_block_meta(
garage.clone(),
&version,
part_number,
0,
first_block_hash,
first_block.len() as u64,
);
2020-04-24 18:47:11 +00:00
let mut put_curr_block = garage
.block_manager
.rpc_put_block(first_block_hash, first_block);
loop {
let (_, _, next_block) =
futures::try_join!(put_curr_block, put_curr_version_block, chunker.next())?;
if let Some(block) = next_block {
md5hasher.update(&block[..]);
sha256hasher.input(&block[..]);
let block_hash = blake2sum(&block[..]);
2020-04-24 18:47:11 +00:00
let block_len = block.len();
2020-04-28 10:18:14 +00:00
put_curr_version_block = put_block_meta(
garage.clone(),
&version,
part_number,
next_offset as u64,
block_hash,
block_len as u64,
);
2020-04-24 18:47:11 +00:00
put_curr_block = garage.block_manager.rpc_put_block(block_hash, block);
next_offset += block_len;
} else {
break;
}
}
let total_size = next_offset as u64;
let data_md5sum = md5hasher.finalize();
let data_sha256sum = sha256hasher.result();
let mut hash = [0u8; 32];
hash.copy_from_slice(&data_sha256sum[..]);
let data_sha256sum = Hash::from(hash);
Ok((total_size, data_md5sum, data_sha256sum))
2020-04-24 18:47:11 +00:00
}
async fn put_block_meta(
garage: Arc<Garage>,
version: &Version,
2020-04-26 18:55:13 +00:00
part_number: u64,
2020-04-24 18:47:11 +00:00
offset: u64,
hash: Hash,
2020-04-26 20:39:32 +00:00
size: u64,
2020-11-08 14:04:30 +00:00
) -> Result<(), GarageError> {
2020-04-24 18:47:11 +00:00
// TODO: don't clone, restart from empty block list ??
let mut version = version.clone();
version.blocks.put(
VersionBlockKey {
2020-04-26 18:55:13 +00:00
part_number,
offset,
},
VersionBlock { hash, size },
);
2020-04-24 18:47:11 +00:00
let block_ref = BlockRef {
block: hash,
version: version.uuid,
deleted: false.into(),
2020-04-24 18:47:11 +00:00
};
futures::try_join!(
garage.version_table.insert(&version),
garage.block_ref_table.insert(&block_ref),
)?;
Ok(())
}
struct BodyChunker {
body: Body,
read_all: bool,
block_size: usize,
buf: VecDeque<u8>,
}
impl BodyChunker {
fn new(body: Body, block_size: usize) -> Self {
Self {
body,
read_all: false,
block_size,
2020-11-29 16:06:55 +00:00
buf: VecDeque::with_capacity(2 * block_size),
2020-04-24 18:47:11 +00:00
}
}
2020-11-08 14:04:30 +00:00
async fn next(&mut self) -> Result<Option<Vec<u8>>, GarageError> {
2020-04-24 18:47:11 +00:00
while !self.read_all && self.buf.len() < self.block_size {
if let Some(block) = self.body.next().await {
let bytes = block?;
trace!("Body next: {} bytes", bytes.len());
self.buf.extend(&bytes[..]);
} else {
self.read_all = true;
}
}
if self.buf.len() == 0 {
Ok(None)
} else if self.buf.len() <= self.block_size {
let block = self.buf.drain(..).collect::<Vec<u8>>();
Ok(Some(block))
} else {
let block = self.buf.drain(..self.block_size).collect::<Vec<u8>>();
Ok(Some(block))
}
}
}
2020-11-29 15:38:01 +00:00
pub fn put_response(version_uuid: UUID, md5sum_hex: String) -> Response<Body> {
Response::builder()
.header("x-amz-version-id", hex::encode(version_uuid))
2020-11-29 15:38:01 +00:00
.header("ETag", format!("\"{}\"", md5sum_hex))
.body(Body::from(vec![]))
.unwrap()
2020-04-26 20:39:32 +00:00
}
pub async fn handle_create_multipart_upload(
garage: Arc<Garage>,
req: &Request<Body>,
bucket: &str,
key: &str,
) -> Result<Response<Body>, Error> {
2020-04-26 20:39:32 +00:00
let version_uuid = gen_uuid();
2020-07-09 15:04:43 +00:00
let headers = get_headers(req)?;
2020-04-26 20:39:32 +00:00
let object_version = ObjectVersion {
uuid: version_uuid,
timestamp: now_msec(),
2020-07-08 15:33:24 +00:00
state: ObjectVersionState::Uploading(headers),
2020-04-26 20:39:32 +00:00
};
let object = Object::new(bucket.to_string(), key.to_string(), vec![object_version]);
garage.object_table.insert(&object).await?;
let mut xml = String::new();
writeln!(&mut xml, r#"<?xml version="1.0" encoding="UTF-8"?>"#).unwrap();
writeln!(
&mut xml,
r#"<InitiateMultipartUploadResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/">"#
)
.unwrap();
writeln!(&mut xml, "\t<Bucket>{}</Bucket>", bucket).unwrap();
writeln!(&mut xml, "\t<Key>{}</Key>", xml_escape(key)).unwrap();
writeln!(
&mut xml,
"\t<UploadId>{}</UploadId>",
hex::encode(version_uuid)
)
.unwrap();
writeln!(&mut xml, "</InitiateMultipartUploadResult>").unwrap();
Ok(Response::new(Body::from(xml.into_bytes())))
2020-04-26 20:39:32 +00:00
}
pub async fn handle_put_part(
garage: Arc<Garage>,
req: Request<Body>,
bucket: &str,
key: &str,
part_number_str: &str,
upload_id: &str,
content_sha256: Option<Hash>,
) -> Result<Response<Body>, Error> {
2020-04-26 20:39:32 +00:00
// Check parameters
let part_number = part_number_str
.parse::<u64>()
2020-11-08 14:04:30 +00:00
.ok_or_bad_request("Invalid part number")?;
2020-04-26 20:39:32 +00:00
2020-11-08 14:04:30 +00:00
let version_uuid = decode_upload_id(upload_id)?;
2020-04-28 10:18:14 +00:00
let content_md5 = match req.headers().get("content-md5") {
Some(x) => Some(x.to_str()?.to_string()),
None => None,
};
2020-04-26 20:39:32 +00:00
// Read first chuck, and at the same time try to get object to see if it exists
let bucket = bucket.to_string();
let key = key.to_string();
let mut chunker = BodyChunker::new(req.into_body(), garage.config.block_size);
let (object, first_block) =
futures::try_join!(garage.object_table.get(&bucket, &key), chunker.next(),)?;
2020-04-26 20:39:32 +00:00
// Check object is valid and multipart block can be accepted
let first_block = first_block.ok_or(Error::BadRequest(format!("Empty body")))?;
2020-11-11 15:12:42 +00:00
let object = object.ok_or(Error::BadRequest(format!("Object not found")))?;
2020-07-08 15:34:37 +00:00
if !object
.versions()
.iter()
.any(|v| v.uuid == version_uuid && v.is_uploading())
{
return Err(Error::NotFound);
2020-04-26 20:39:32 +00:00
}
// Copy block to store
let version = Version::new(version_uuid, bucket, key, false);
let first_block_hash = blake2sum(&first_block[..]);
let (_, data_md5sum, data_sha256sum) = read_and_put_blocks(
2020-04-28 10:18:14 +00:00
&garage,
&version,
2020-04-28 10:18:14 +00:00
part_number,
first_block,
first_block_hash,
&mut chunker,
)
.await?;
2020-04-26 20:39:32 +00:00
// Verify that checksums map
2020-11-22 10:04:33 +00:00
ensure_checksum_matches(
data_md5sum.as_slice(),
data_sha256sum,
2020-11-22 10:04:33 +00:00
content_md5.as_deref(),
content_sha256,
)?;
// Store part etag in version
let data_md5sum_hex = hex::encode(data_md5sum);
let mut version = version;
2021-03-10 20:50:09 +00:00
version
.parts_etags
.put(part_number, data_md5sum_hex.clone());
garage.version_table.insert(&version).await?;
2020-11-29 15:38:01 +00:00
let response = Response::builder()
.header("ETag", format!("\"{}\"", data_md5sum_hex))
2020-11-29 15:38:01 +00:00
.body(Body::from(vec![]))
.unwrap();
Ok(response)
2020-04-26 20:39:32 +00:00
}
pub async fn handle_complete_multipart_upload(
garage: Arc<Garage>,
req: Request<Body>,
2020-04-26 20:39:32 +00:00
bucket: &str,
key: &str,
upload_id: &str,
content_sha256: Option<Hash>,
) -> Result<Response<Body>, Error> {
let body = hyper::body::to_bytes(req.into_body()).await?;
verify_signed_content(content_sha256, &body[..])?;
let body_xml = roxmltree::Document::parse(&std::str::from_utf8(&body)?)?;
2021-02-23 17:46:25 +00:00
let body_list_of_parts = parse_complete_multpart_upload_body(&body_xml)
.ok_or_bad_request("Invalid CompleteMultipartUpload XML")?;
debug!(
"CompleteMultipartUpload list of parts: {:?}",
body_list_of_parts
);
2020-11-08 14:04:30 +00:00
let version_uuid = decode_upload_id(upload_id)?;
2020-04-26 20:39:32 +00:00
let bucket = bucket.to_string();
let key = key.to_string();
let (object, version) = futures::try_join!(
garage.object_table.get(&bucket, &key),
garage.version_table.get(&version_uuid, &EmptyKey),
)?;
2020-11-11 15:12:42 +00:00
let object = object.ok_or(Error::BadRequest(format!("Object not found")))?;
2020-07-08 15:34:37 +00:00
let object_version = object
.versions()
.iter()
.find(|v| v.uuid == version_uuid && v.is_uploading());
2020-04-26 20:39:32 +00:00
let mut object_version = match object_version {
None => return Err(Error::NotFound),
2020-04-26 20:39:32 +00:00
Some(x) => x.clone(),
};
2020-11-11 15:12:42 +00:00
let version = version.ok_or(Error::BadRequest(format!("Version not found")))?;
if version.blocks.len() == 0 {
2020-04-26 20:39:32 +00:00
return Err(Error::BadRequest(format!("No data was uploaded")));
}
2020-07-08 15:34:37 +00:00
let headers = match object_version.state {
ObjectVersionState::Uploading(headers) => headers.clone(),
_ => unreachable!(),
};
2020-04-26 20:39:32 +00:00
// Check that the list of parts they gave us corresponds to the parts we have here
println!("Expected parts from request: {:?}", body_list_of_parts);
println!("Parts stored in version: {:?}", version.parts_etags.items());
let parts = version
.parts_etags
.items()
2021-02-23 17:46:25 +00:00
.iter()
.map(|pair| (&pair.0, &pair.1));
2021-02-23 17:46:25 +00:00
let same_parts = body_list_of_parts
.iter()
.map(|x| (&x.part_number, &x.etag))
.eq(parts);
if !same_parts {
return Err(Error::BadRequest(format!("We don't have the same parts")));
}
// Calculate etag of final object
// To understand how etags are calculated, read more here:
// https://teppen.io/2018/06/23/aws_s3_etags/
let num_parts = version.blocks.items().last().unwrap().0.part_number
- version.blocks.items().first().unwrap().0.part_number
2020-12-05 18:23:46 +00:00
+ 1;
let mut etag_md5_hasher = Md5::new();
for (_, etag) in version.parts_etags.items().iter() {
etag_md5_hasher.update(etag.as_bytes());
}
2021-03-10 20:50:09 +00:00
let etag = format!("{}-{}", hex::encode(etag_md5_hasher.finalize()), num_parts);
2020-12-05 18:23:46 +00:00
// Calculate total size of final object
2020-04-28 10:18:14 +00:00
let total_size = version
.blocks
.items()
2020-04-28 10:18:14 +00:00
.iter()
.map(|x| x.1.size)
2020-04-28 10:18:14 +00:00
.fold(0, |x, y| x + y);
// Write final object version
2020-07-08 15:34:37 +00:00
object_version.state = ObjectVersionState::Complete(ObjectVersionData::FirstBlock(
ObjectVersionMeta {
headers,
size: total_size,
etag,
2020-07-08 15:34:37 +00:00
},
version.blocks.items()[0].1.hash,
2020-07-08 15:34:37 +00:00
));
2020-07-08 15:33:24 +00:00
2020-04-26 20:39:32 +00:00
let final_object = Object::new(bucket.clone(), key.clone(), vec![object_version]);
garage.object_table.insert(&final_object).await?;
// Send response saying ok we're done
2020-04-26 20:39:32 +00:00
let mut xml = String::new();
writeln!(&mut xml, r#"<?xml version="1.0" encoding="UTF-8"?>"#).unwrap();
writeln!(
&mut xml,
r#"<CompleteMultipartUploadResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/">"#
)
.unwrap();
2020-04-28 10:18:14 +00:00
writeln!(
&mut xml,
"\t<Location>{}</Location>",
garage.config.s3_api.s3_region
)
.unwrap();
2020-04-26 20:39:32 +00:00
writeln!(&mut xml, "\t<Bucket>{}</Bucket>", bucket).unwrap();
writeln!(&mut xml, "\t<Key>{}</Key>", xml_escape(&key)).unwrap();
writeln!(&mut xml, "</CompleteMultipartUploadResult>").unwrap();
Ok(Response::new(Body::from(xml.into_bytes())))
2020-04-26 20:39:32 +00:00
}
2020-04-26 20:46:21 +00:00
pub async fn handle_abort_multipart_upload(
garage: Arc<Garage>,
bucket: &str,
key: &str,
upload_id: &str,
) -> Result<Response<Body>, Error> {
2020-11-08 14:04:30 +00:00
let version_uuid = decode_upload_id(upload_id)?;
2020-04-26 20:46:21 +00:00
2020-04-28 10:18:14 +00:00
let object = garage
.object_table
.get(&bucket.to_string(), &key.to_string())
.await?;
2020-11-11 15:12:42 +00:00
let object = object.ok_or(Error::BadRequest(format!("Object not found")))?;
2020-07-08 15:34:37 +00:00
let object_version = object
.versions()
.iter()
.find(|v| v.uuid == version_uuid && v.is_uploading());
2020-04-26 20:46:21 +00:00
let mut object_version = match object_version {
None => return Err(Error::NotFound),
2020-04-26 20:46:21 +00:00
Some(x) => x.clone(),
};
object_version.state = ObjectVersionState::Aborted;
let final_object = Object::new(bucket.to_string(), key.to_string(), vec![object_version]);
garage.object_table.insert(&final_object).await?;
Ok(Response::new(Body::from(vec![])))
2020-04-26 20:46:21 +00:00
}
2020-04-26 20:39:32 +00:00
fn get_mime_type(req: &Request<Body>) -> Result<String, Error> {
Ok(req
.headers()
.get(hyper::header::CONTENT_TYPE)
.map(|x| x.to_str())
.unwrap_or(Ok("blob"))?
.to_string())
}
2020-07-09 15:04:43 +00:00
fn get_headers(req: &Request<Body>) -> Result<ObjectVersionHeaders, Error> {
let content_type = get_mime_type(req)?;
let other_headers = vec![
hyper::header::CACHE_CONTROL,
hyper::header::CONTENT_DISPOSITION,
hyper::header::CONTENT_ENCODING,
hyper::header::CONTENT_LANGUAGE,
hyper::header::EXPIRES,
];
let mut other = BTreeMap::new();
for h in other_headers.iter() {
if let Some(v) = req.headers().get(h) {
match v.to_str() {
Ok(v_str) => {
other.insert(h.to_string(), v_str.to_string());
}
Err(e) => {
warn!("Discarding header {}, error in .to_str(): {}", h, e);
}
2020-07-09 15:04:43 +00:00
}
}
}
Ok(ObjectVersionHeaders {
content_type,
other,
2020-07-09 15:04:43 +00:00
})
}
2020-11-08 14:04:30 +00:00
fn decode_upload_id(id: &str) -> Result<UUID, Error> {
let id_bin = hex::decode(id).ok_or_bad_request("Invalid upload ID")?;
2020-04-26 20:39:32 +00:00
if id_bin.len() != 32 {
2020-11-08 14:04:30 +00:00
return None.ok_or_bad_request("Invalid upload ID");
2020-04-26 20:39:32 +00:00
}
let mut uuid = [0u8; 32];
uuid.copy_from_slice(&id_bin[..]);
Ok(UUID::from(uuid))
}
#[derive(Debug)]
struct CompleteMultipartUploadPart {
etag: String,
part_number: u64,
}
2021-02-23 17:46:25 +00:00
fn parse_complete_multpart_upload_body(
xml: &roxmltree::Document,
) -> Option<Vec<CompleteMultipartUploadPart>> {
let mut parts = vec![];
let root = xml.root();
let cmu = root.first_child()?;
if !cmu.has_tag_name("CompleteMultipartUpload") {
return None;
}
for item in cmu.children() {
if item.has_tag_name("Part") {
let etag = item.children().find(|e| e.has_tag_name("ETag"))?.text()?;
2021-02-23 17:46:25 +00:00
let part_number = item
.children()
.find(|e| e.has_tag_name("PartNumber"))?
.text()?;
parts.push(CompleteMultipartUploadPart {
etag: etag.trim_matches('"').to_string(),
part_number: part_number.parse().ok()?,
});
} else {
return None;
}
}
Some(parts)
}