Deuxfleurs/bottin
23
4
Fork 2
Code Issues 7 Pull requests 1 Releases Activity

Fix wrong handling of multi value attributes #13

Merged
lx merged 1 commit from Kidswiss/bottin:fix/multivalue_attr into main 2022-02-14 11:13:31 +00:00
Conversation 0 Commits 1 Files changed 1 +3 -2
Kidswiss commented 2022-02-10 19:53:33 +00:00
Contributor
Copy link

While ldapsearch doesn't seem to mind, apps like keycloak seem to have
issues with adding multiple attributes with different values. While
the resulting ldif in ldapsearch is indistinguishable there seems to
be a slight different on the protocol level.

If adding multiple attributes with the same name and different values,
keycloak will only see the last entry. But adding a single attribute
a slice of values is seems to handle it correctly.

While ldapsearch doesn't seem to mind, apps like keycloak seem to have issues with adding multiple attributes with different values. While the resulting ldif in ldapsearch is indistinguishable there seems to be a slight different on the protocol level. If adding multiple attributes with the same name and different values, keycloak will only see the last entry. But adding a single attribute a slice of values is seems to handle it correctly.
Kidswiss added 1 commit 2022-02-10 19:53:34 +00:00
Fix wrong handling of multi value attributes
All checks were successful
continuous-integration/drone/pr Build is passing
Details
d28e669676 
While ldapsearch doesn't seem to mind, apps like keycloak seem to have
issues with adding multiple attributes with different values. While
the resulting ldif in ldapsearch is indistinguishable there seems to
be a slight different on the protocol level.

If adding multiple attributes with the same name and different values,
keycloak will only see the last entry. But adding a single attribute
a slice of values is seems to handle it correctly.
lx approved these changes 2022-02-14 11:13:24 +00:00
lx left a comment
Owner
Copy link

Thanks for the fix!

Thanks for the fix!
lx merged commit 9ce0d22c99 into main 2022-02-14 11:13:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lx
Labels
Clear labels   
bug

Something does not work as intended

  
doc

Explain how Bottin works

  
engineering

We want to improve our code

  
feature

New exciting things we want!

No labels
bug
doc
engineering
feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/bottin#13
No description provided.
Delete branch "Kidswiss/bottin:fix/multivalue_attr"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?