Vendor GoLDAP and fix Integer Encoding #8

Closed

quentin wants to merge 2 commits from import_goldap into main

pull from: import_goldap

merge into: Deuxfleurs:main

Deuxfleurs:main

Deuxfleurs:feat/better-docker

Deuxfleurs:lowercase_scheme

Deuxfleurs:test-go-Bottin

Conversation 0 Commits 2 Files changed 91 +11997 -33

quentin commented 2021-09-16 10:55:42 +00:00

Owner

Copy link

Fixes #3

based on:

• https://ldap.com/ldapv3-wire-protocol-reference-asn1-ber/
• https://pkg.go.dev/encoding/asn1

I fixed the following bug:

• https://github.com/lor00x/goldap/issues/3
• and a regression caused by the fact that ASN.1 integer encoding must not be used to write lengths as encoding differs.

I disabled the "Reconnect()" function in the test runner as now we can run all the tests with a single connection.

Also, for the future, I would recommend to totally drop this library and replace it with the clean ASN.1 library shipped with Go. If I have some time, I will try to hack on it!

Fixes #3 based on: - https://ldap.com/ldapv3-wire-protocol-reference-asn1-ber/ - https://pkg.go.dev/encoding/asn1 I fixed the following bug: - https://github.com/lor00x/goldap/issues/3 - and a regression caused by the fact that ASN.1 integer encoding must not be used to write lengths as encoding differs. I disabled the "Reconnect()" function in the test runner as now we can run all the tests with a single connection. Also, for the future, I would recommend to totally drop this library and replace it with the clean ASN.1 library shipped with Go. If I have some time, I will try to hack on it!

quentin added 23 commits 2021-09-16 10:55:43 +00:00

Tests écrit en go sur la réaction du serveur Bottin ... 75f4a916c3

Tests réalisés:
- création aléatoires des Users et Groups- LDAP ADD
- vérifications des attributs sur Consul et ceux qu'on a ajouté - LDAP
  Search
- modifications des attributs des users et groups puis vérifications -
  LDAP Modify

Mise en place du code source goldap ... 9e4b4a0162

Changement des imports dans les fichiers go de bottin et ldapserver.
Rajout d'un fichier txt dans test-automatique pour reproduire le bug des
requêtes ldap.

Ajout des fichiers WireSharks scan pour problème messageID 32cce4c4d3

test_automatique fini et fonctionnel f294b66874

Rajout script bash pour drone f93f9e6958

Création script bash de test 5fbe39c38a

Modification server init() ... 2f350965ce

Lecture Password
Ajout d'une lecture de password à travers la variable d'environnement
"BOTTIN_DEFAULT_ADMIN_PW" sinon génère aléatoirement

Ajout Nouvelle Version integration.go aeac8faf15

Add test_automatic/integration binarie bfd12a48c4

Ajout d'une step pour lancer le test integration 139a40bdf3

Test .drone ls step bootin 09512a271d

Add sign to .drone 986ef6d59d

Add sign and bash command 974d8806d8

Add sign and transform bash to ash script a9d9484f23

Add sign Drone and suppress opennssl package in script 3e658ac201

Test bottin comportment a9b04a255f

Add config.json.test to use in Go test eb7f00c526

Add launch script and remove openssl e4778a9a89

Change return code 143 to 0 3f8e633045

Exit 0 in the script 49fcbcae7c

suppress kill in the script(provoked error 143) 2f09e10933

Delete goldap, switch to another branch 7c8bd455e6

Add goldap source files + modified import 5f0f6a730a

quentin force-pushed import_goldap from 0057456ed2 to 24e591c62a 2021-09-16 11:13:43 +00:00 Compare

quentin requested review from lx 2021-09-16 11:14:23 +00:00

quentin closed this pull request 2021-09-16 11:31:13 +00:00

quentin removed review request for lx 2021-09-16 13:22:06 +00:00

All checks were successful

Hide all checks

continuous-integration/drone/pr Build is passing

Details

continuous-integration/drone/push Build is passing

Required

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something does not work as intended

  

doc

Explain how Bottin works

  

engineering

We want to improve our code

  

feature

New exciting things we want!

No labels

bug

doc

engineering

feature

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/bottin#8

No description provided.