Vendor GoLDAP and fix Integer Encoding #8

Closed

quentin wants to merge 2 commits from import_goldap into main

quentin commented

2021-09-16 10:55:42 +00:00

Owner

Fixes #3

based on:

I fixed the following bug:

https://github.com/lor00x/goldap/issues/3
and a regression caused by the fact that ASN.1 integer encoding must not be used to write lengths as encoding differs.

I disabled the "Reconnect()" function in the test runner as now we can run all the tests with a single connection.

Also, for the future, I would recommend to totally drop this library and replace it with the clean ASN.1 library shipped with Go. If I have some time, I will try to hack on it!

Fixes #3 based on: - https://ldap.com/ldapv3-wire-protocol-reference-asn1-ber/ - https://pkg.go.dev/encoding/asn1 I fixed the following bug: - https://github.com/lor00x/goldap/issues/3 - and a regression caused by the fact that ASN.1 integer encoding must not be used to write lengths as encoding differs. I disabled the "Reconnect()" function in the test runner as now we can run all the tests with a single connection. Also, for the future, I would recommend to totally drop this library and replace it with the clean ASN.1 library shipped with Go. If I have some time, I will try to hack on it!

quentin force-pushed import_goldap from 0057456ed2 to 24e591c62a

2021-09-16 11:13:43 +00:00

Compare