Deuxfleurs/garage
48
56
Fork 73
Code Issues 100 Pull requests 13 Releases 30 Wiki Activity

Allow linking against system-provided libsqlite
Some checks are pending
continuous-integration/drone/push Build is pending
Details
continuous-integration/drone/pr Build is pending
Details

Browse source 
Unfortunately, rusqlite uses the opposite logic for enabling/disabling
bundled libraries to others (libsodium-sys, zstd-sys). Cargo features
are very limited and doesn't allow to enable feature A in a dependency
iff feature B is disabled.

Note, lmdb-rkv-sys doesn't need any special treatment because it
automatically links against system liblmdb if found via pkgconf.

Linux distros should build garage with
`--no-default-features --features system-libs` to disable bundled-libs
and enable system-libs.
This commit is contained in:
Jakub Jirutka 2022-09-03 19:05:32 +02:00
parent a6e40b75ea
commit 7511ba5530
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/db/Cargo.toml
View file

@ -22,7 +22,7 @@ hexdump = "0.1"
tracing = "0.1.30" tracing = "0.1.30"
heed = "0.11" heed = "0.11"
rusqlite = { version = "0.27", features = ["bundled"] } rusqlite = "0.27"
sled = "0.34" sled = "0.34"
# cli deps # cli deps
@ -33,4 +33,5 @@ pretty_env_logger = { version = "0.4", optional = true }
mktemp = "0.4" mktemp = "0.4"
[features] [features]
bundled-libs = [ "rusqlite/bundled" ]
cli = ["clap", "pretty_env_logger"] cli = ["clap", "pretty_env_logger"]

8
src/garage/Cargo.toml
View file

@ -74,6 +74,14 @@ base64 = "0.13"
[features] [features]
default = [ "bundled-libs" ]
kubernetes-discovery = [ "garage_rpc/kubernetes-discovery" ] kubernetes-discovery = [ "garage_rpc/kubernetes-discovery" ]
k2v = [ "garage_util/k2v", "garage_api/k2v" ] k2v = [ "garage_util/k2v", "garage_api/k2v" ]
# NOTE: bundled-libs and system-libs should be treat as mutually exclusive;
# exactly one of them should be enabled.
# Use bundled libsqlite instead of linking against system-provided.
bundled-libs = [ "garage_db/bundled-libs" ]
# Link against system-provided libsodium and libzstd.
system-libs = [ "garage_block/system-libs", "garage_rpc/system-libs", "sodiumoxide/use-pkg-config" ] system-libs = [ "garage_block/system-libs", "garage_rpc/system-libs", "sodiumoxide/use-pkg-config" ]