implement repair procedure to fix inconsistent bucket aliases

src/model/helper/locked.rs

@@ -492,79 +492,84 @@ impl<'a> LockedHelper<'a> {
 			// 2. List all aliases declared in bucket_alias_table and key_table
 			//    Take note of aliases that point to non-existing buckets
 			let mut global_aliases: HashMap<String, Uuid> = HashMap::new();
-			let mut local_aliases: HashMap<(String, String), Uuid> = HashMap::new();
 
-			let mut delete_global = vec![];
-			let mut delete_local = vec![];
-
-			for item in tx.range::<&[u8], _>(&self.0.bucket_alias_table.data.store, ..)? {
-				let mut alias = self
-					.0
-					.bucket_alias_table
-					.data
-					.decode_entry(&(item?.1))
-					.map_err(db::TxError::Abort)?;
-				if let Some(id) = alias.state.get() {
-					if all_buckets.contains(&id) {
-						// keep aliases
-						global_aliases.insert(alias.name().to_string(), *id);
-					} else {
-						// delete alias
-						warn!(
-							"global alias: remove {} -> {:?} (bucket is deleted)",
-							alias.name(),
-							id
-						);
-						alias.state.update(None);
-						delete_global.push(alias);
-					}
-				}
-			}
-
-			for item in tx.range::<&[u8], _>(&self.0.key_table.data.store, ..)? {
-				let mut key = self
-					.0
-					.key_table
-					.data
-					.decode_entry(&(item?.1))
-					.map_err(db::TxError::Abort)?;
-				let Some(p) = key.state.as_option_mut() else {
-					continue;
-				};
-				let mut has_changes = false;
-				for (name, _, to) in p.local_aliases.items().to_vec() {
-					if let Some(id) = to {
-						if all_buckets.contains(&id) {
-							local_aliases.insert((key.key_id.clone(), name.clone()), id);
+			{
+				let mut delete_global = vec![];
+				for item in tx.range::<&[u8], _>(&self.0.bucket_alias_table.data.store, ..)? {
+					let mut alias = self
+						.0
+						.bucket_alias_table
+						.data
+						.decode_entry(&(item?.1))
+						.map_err(db::TxError::Abort)?;
+					if let Some(id) = alias.state.get() {
+						if all_buckets.contains(id) {
+							// keep aliases
+							global_aliases.insert(alias.name().to_string(), *id);
 						} else {
+							// delete alias
 							warn!(
-								"local alias: remove ({}, {}) -> {:?} (bucket is deleted)",
-								key.key_id, name, id
+								"global alias: remove {} -> {:?} (bucket is deleted)",
+								alias.name(),
+								id
 							);
-							p.local_aliases.update_in_place(name.clone(), None);
-							has_changes = true;
+							alias.state.update(None);
+							delete_global.push(alias);
 						}
 					}
 				}
-				if has_changes {
-					delete_local.push(key);
+
+				info!("number of global aliases: {}", global_aliases.len());
+
+				info!("global alias table: {} entries fixed", delete_global.len());
+				for ga in delete_global {
+					debug!("Enqueue update to global alias table: {:?}", ga);
+					self.0.bucket_alias_table.queue_insert(tx, &ga)?;
 				}
 			}
 
-			info!("number of global aliases: {}", global_aliases.len());
-			info!("number of local aliases: {}", local_aliases.len());
+			let mut local_aliases: HashMap<(String, String), Uuid> = HashMap::new();
 
-			// 3. Enqueue non-existing aliases for deletion
-			info!("global alias table: {} entries fixed", delete_global.len());
-			for ga in delete_global {
-				debug!("Enqueue update to global alias table: {:?}", ga);
-				self.0.bucket_alias_table.queue_insert(tx, &ga)?;
-			}
+			{
+				let mut delete_local = vec![];
 
-			info!("local alias table: {} entries fixed", delete_local.len());
-			for la in delete_local {
-				debug!("Enqueue update to local alias table: {:?}", la);
-				self.0.key_table.queue_insert(tx, &la)?;
+				for item in tx.range::<&[u8], _>(&self.0.key_table.data.store, ..)? {
+					let mut key = self
+						.0
+						.key_table
+						.data
+						.decode_entry(&(item?.1))
+						.map_err(db::TxError::Abort)?;
+					let Some(p) = key.state.as_option_mut() else {
+						continue;
+					};
+					let mut has_changes = false;
+					for (name, _, to) in p.local_aliases.items().to_vec() {
+						if let Some(id) = to {
+							if all_buckets.contains(&id) {
+								local_aliases.insert((key.key_id.clone(), name.clone()), id);
+							} else {
+								warn!(
+									"local alias: remove ({}, {}) -> {:?} (bucket is deleted)",
+									key.key_id, name, id
+								);
+								p.local_aliases.update_in_place(name.clone(), None);
+								has_changes = true;
+							}
+						}
+					}
+					if has_changes {
+						delete_local.push(key);
+					}
+				}
+
+				info!("number of local aliases: {}", local_aliases.len());
+
+				info!("local alias table: {} entries fixed", delete_local.len());
+				for la in delete_local {
+					debug!("Enqueue update to local alias table: {:?}", la);
+					self.0.key_table.queue_insert(tx, &la)?;
+				}
 			}
 
 			// 4. Reverse the alias maps to determine the aliases per-bucket
@@ -594,32 +599,36 @@ impl<'a> LockedHelper<'a> {
 				};
 
 				// fix global aliases
-				let ga = bucket_global.remove(&bucket.id).unwrap_or_default();
-				for (name, _, active) in param.aliases.items().to_vec() {
-					if active && !ga.contains(&name) {
-						warn!("bucket {:?}: remove global alias {}", bucket.id, name);
-						param.aliases.update_in_place(name, false);
+				{
+					let ga = bucket_global.remove(&bucket.id).unwrap_or_default();
+					for (name, _, active) in param.aliases.items().to_vec() {
+						if active && !ga.contains(&name) {
+							warn!("bucket {:?}: remove global alias {}", bucket.id, name);
+							param.aliases.update_in_place(name, false);
+						}
 					}
-				}
-				for name in ga.iter() {
-					if param.aliases.get(&name).copied().unwrap_or(false) == false {
-						warn!("bucket {:?}: add global alias {}", bucket.id, name);
-						param.aliases.update_in_place(name.to_string(), true);
+					for name in ga.iter() {
+						if param.aliases.get(&name).copied().unwrap_or(false) == false {
+							warn!("bucket {:?}: add global alias {}", bucket.id, name);
+							param.aliases.update_in_place(name.to_string(), true);
+						}
 					}
 				}
 
 				// fix local aliases
-				let la = bucket_local.remove(&bucket.id).unwrap_or_default();
-				for (pair, _, active) in param.local_aliases.items().to_vec() {
-					if active && !la.contains(&pair) {
-						warn!("bucket {:?}: remove local alias {:?}", bucket.id, pair);
-						param.local_aliases.update_in_place(pair, false);
+				{
+					let la = bucket_local.remove(&bucket.id).unwrap_or_default();
+					for (pair, _, active) in param.local_aliases.items().to_vec() {
+						if active && !la.contains(&pair) {
+							warn!("bucket {:?}: remove local alias {:?}", bucket.id, pair);
+							param.local_aliases.update_in_place(pair, false);
+						}
 					}
-				}
-				for pair in la.iter() {
-					if param.local_aliases.get(&pair).copied().unwrap_or(false) == false {
-						warn!("bucket {:?}: add local alias {:?}", bucket.id, pair);
-						param.local_aliases.update_in_place(pair.clone(), true);
+					for pair in la.iter() {
+						if param.local_aliases.get(&pair).copied().unwrap_or(false) == false {
+							warn!("bucket {:?}: add local alias {:?}", bucket.id, pair);
+							param.local_aliases.update_in_place(pair.clone(), true);
+						}
 					}
 				}