Deuxfleurs/garage
41
56
Fork 73
Code Issues 98 Pull requests 14 Releases 30 Wiki Activity

MD5 sums are broken and s3cmd does not like that #1

New issue
Closed
opened 2020-07-05 19:50:12 +00:00 by quentin · 4 comments
quentin commented 2020-07-05 19:50:12 +00:00
Owner
Copy link
[quentin@lheureduthe nomad]$ s3cmd --no-check-certificate put ~/Images/happy.jpg s3://nextcloud/happy.jpg
upload: '/home/quentin/Images/happy.jpg' -> 's3://nextcloud/happy.jpg'  [1 of 1]
 270593 of 270593   100% in    0s     2.16 MB/s  done
WARNING: MD5 Sums don't match!
WARNING: Retrying upload of /home/quentin/Images/happy.jpg
upload: '/home/quentin/Images/happy.jpg' -> 's3://nextcloud/happy.jpg'  [1 of 1]
 270593 of 270593   100% in    0s     3.03 MB/s  done
WARNING: MD5 Sums don't match!
WARNING: Retrying upload of /home/quentin/Images/happy.jpg
upload: '/home/quentin/Images/happy.jpg' -> 's3://nextcloud/happy.jpg'  [1 of 1]
 270593 of 270593   100% in    0s     2.22 MB/s  done
WARNING: MD5 Sums don't match!
WARNING: Retrying upload of /home/quentin/Images/happy.jpg
upload: '/home/quentin/Images/happy.jpg' -> 's3://nextcloud/happy.jpg'  [1 of 1]
 270593 of 270593   100% in    0s     2.66 MB/s  done
WARNING: MD5 Sums don't match!
WARNING: Retrying upload of /home/quentin/Images/happy.jpg
upload: '/home/quentin/Images/happy.jpg' -> 's3://nextcloud/happy.jpg'  [1 of 1]
 270593 of 270593   100% in    0s     3.11 MB/s  done
WARNING: MD5 Sums don't match!
WARNING: Retrying upload of /home/quentin/Images/happy.jpg
upload: '/home/quentin/Images/happy.jpg' -> 's3://nextcloud/happy.jpg'  [1 of 1]
 270593 of 270593   100% in    0s     2.65 MB/s  done
WARNING: MD5 Sums don't match!
WARNING: Too many failures. Giving up on '/home/quentin/Images/happy.jpg'
ERROR: Upload of '/home/quentin/Images/happy.jpg' failed too many times (Last reason: )

[quentin@lheureduthe tmp]$ s3cmd --no-check-certificate get s3://nextcloud/happy.jpg lol.jpg
download: 's3://nextcloud/happy.jpg' -> 'lol.jpg'  [1 of 1]
 270593 of 270593   100% in    0s     4.41 MB/s  done
WARNING: MD5 signatures do not match: computed=cd3d85d7eda3d58bde2107dae5873242, received=
``` [quentin@lheureduthe nomad]$ s3cmd --no-check-certificate put ~/Images/happy.jpg s3://nextcloud/happy.jpg upload: '/home/quentin/Images/happy.jpg' -> 's3://nextcloud/happy.jpg' [1 of 1] 270593 of 270593 100% in 0s 2.16 MB/s done WARNING: MD5 Sums don't match! WARNING: Retrying upload of /home/quentin/Images/happy.jpg upload: '/home/quentin/Images/happy.jpg' -> 's3://nextcloud/happy.jpg' [1 of 1] 270593 of 270593 100% in 0s 3.03 MB/s done WARNING: MD5 Sums don't match! WARNING: Retrying upload of /home/quentin/Images/happy.jpg upload: '/home/quentin/Images/happy.jpg' -> 's3://nextcloud/happy.jpg' [1 of 1] 270593 of 270593 100% in 0s 2.22 MB/s done WARNING: MD5 Sums don't match! WARNING: Retrying upload of /home/quentin/Images/happy.jpg upload: '/home/quentin/Images/happy.jpg' -> 's3://nextcloud/happy.jpg' [1 of 1] 270593 of 270593 100% in 0s 2.66 MB/s done WARNING: MD5 Sums don't match! WARNING: Retrying upload of /home/quentin/Images/happy.jpg upload: '/home/quentin/Images/happy.jpg' -> 's3://nextcloud/happy.jpg' [1 of 1] 270593 of 270593 100% in 0s 3.11 MB/s done WARNING: MD5 Sums don't match! WARNING: Retrying upload of /home/quentin/Images/happy.jpg upload: '/home/quentin/Images/happy.jpg' -> 's3://nextcloud/happy.jpg' [1 of 1] 270593 of 270593 100% in 0s 2.65 MB/s done WARNING: MD5 Sums don't match! WARNING: Too many failures. Giving up on '/home/quentin/Images/happy.jpg' ERROR: Upload of '/home/quentin/Images/happy.jpg' failed too many times (Last reason: ) ``` ``` [quentin@lheureduthe tmp]$ s3cmd --no-check-certificate get s3://nextcloud/happy.jpg lol.jpg download: 's3://nextcloud/happy.jpg' -> 'lol.jpg' [1 of 1] 270593 of 270593 100% in 0s 4.41 MB/s done WARNING: MD5 signatures do not match: computed=cd3d85d7eda3d58bde2107dae5873242, received= ```
quentin added the
action
for-newcomers
 label 2020-07-05 19:50:54 +00:00
lx commented 2020-07-08 12:12:34 +00:00
Owner
Copy link

Related: Garage currently does not implement checking of the MD5 sum of the uploaded data, which should match the Content-MD5 header. Should be implemented.

Related: Garage currently does not implement checking of the MD5 sum of the uploaded data, which should match the `Content-MD5` header. Should be implemented.
lx commented 2020-07-08 12:14:13 +00:00
Owner
Copy link

WRT the original bug, Amazon says in the docs that the returned ETag can be compared against the MD5 of the file for the PutObject API call and that they should match. This is inconsistent with the fact that ETags are supposed to be opaque identifiers attributed by the system, but if S3 clients rely on this behaviour we have to respect it. Garage doesn't care about ETags so we can do whatever with that field.

WRT the original bug, Amazon says in the docs that the returned ETag can be compared against the MD5 of the file for the PutObject API call and that they should match. This is inconsistent with the fact that ETags are supposed to be opaque identifiers attributed by the system, but if S3 clients rely on this behaviour we have to respect it. Garage doesn't care about ETags so we can do whatever with that field.
😆 1
lx commented 2020-07-08 12:16:03 +00:00
Owner
Copy link

Some information about ETags: https://teppen.io/2018/06/23/aws_s3_etags/
We should implement the same thing for maximum compatibility.

Some information about ETags: https://teppen.io/2018/06/23/aws_s3_etags/ We should implement the same thing for maximum compatibility.
👍 1
lx commented 2020-07-13 14:52:56 +00:00
Owner
Copy link

Fixed for PutObject, original issue is solved. Creating other tickets for the other things.

Fixed for PutObject, original issue is solved. Creating other tickets for the other things.
lx closed this issue 2020-07-13 14:52:57 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
update-dependencies-1.1
feat-metrics-metadata-engine
improve-secret-error-message
hotfix/1.0.0-rc1-red-ftr-wquorum
main-0.9.x
db-no-unsafe
main-0.8.x
k2v/shared_http_client
feat/website-redir
smithy2
test/compilation
poc/nomad-ci
test-ci-wait
pnet_datalink-0.33.0
optimal-layout
k2v-watch-range
db-debug-log
build-convert-db
demonstrate-cargo2nix-bug
dangerous/no-fsync
dev0.7.3
doc/benchmarks
bug/check_static
bucket-cors-more
storage-optimizations
old-main
v1.0.1
v1.0.0
v0.9.4
v1.0.0-rc1
v0.8.7
v0.9.3
v0.9.2
v0.8.6
v0.9.2-rc1
v0.9.1
v0.8.5
v0.10.0-beta1
v0.9.0
v0.9.0-rc2
v0.9.0-rc1
v0.9.0-beta4
v0.9.0-beta3
v0.9.0-beta2
v0.8.4
v0.9.0-beta1
v0.8.3
v0.8.3-rc1
format_table-v0.1.1
format_table-v0.1.0
v0.8.2
v0.8.1
v0.8.0
v0.8.0-rc2
v0.8.0-rc1
v0.8.0-dangerous-no-fsync
v0.8.0-beta2-k2v
v0.8.0-beta2
v0.8.0-beta1-k2v
v0.8.0-beta1
v0.7.99.3-k2v
v0.7.3
v0.7.3-beta2
v0.7.3-beta1
v0.7.2.1
v0.7.2
v0.7.2_ci-test-2
v0.7.2+ci-test-version
v0.7.99.2-k2v
v0.7.99.1-k2v
v0.7.99-k2v
v0.7.2-k2v
v0.7.1-admin-k2v-2
v0.7.1-admin-k2v
v0.7.1-k2v
v0.7.1
v0.7.0
v0.7.0-rc1
v0.6.1
v0.6.0
v0.6.0-rc1
v0.5.1
v0.5.0.1
v0.5.0
v0.5-beta1
v0.4.0
v0.4-rc2
v0.4-rc1
0.4-beta
0.4-alpha
v0.3.0.2
v0.3.0.1
v0.3.0
v0.2.1.5
v0.2.1
v0.2.0
0.1.1b
0.1.1
0.1.0b
0.1.0
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#1
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?