Ignore parameters on ListBuckets #175
Labels
No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
No Milestone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#175
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
WinSCP sends a
?max-keys=1
when calling ListBuckets.Currently, we send a BadRequest if we call ListBuckets with any parameter.
So WinSCP does not like our response:
AWS S3 documentation does not mention
max-keys
in its doc. We did some tests on minio that tolerate the parameter but ignore it (we putmax-keys=1
but it still returned all our buckets). By reviewing its source code, it seems that Ceph is also tolerating but ignoring this parameter. (source 1, source 2, doc). We did not make any tests on AWS yet. We are not aware of any implementation following this key on ListBuckets.Deleting this check makes WinSCP happy: I have done the test. It should be a simple fix.
See #176 that proposes to add WinSCP to our tests.