ETags in returned XML are missing quotes #190
Labels
No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#190
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
XML returned by AWS S3 normally looks like this when it contains an ETag field:
Garage currently returns XML that looks like this:
If we add the quotes to the value of the field,
quick_xml
serializes it like this:Which is bad. Fixing this depends on the following feature of the
quick_xml
crate: https://github.com/tafia/quick-xml/issues/350Actually AWS encode quotes like quick_xml does
Sample response obtained from AWS
(indentation added by myself for readability)
Thanks @trinity-1686a, so we just need to add the quotes where they are missing.
Fixed in #188