Incorrect behavior on UploadPart when a part already exists #197

New issue

Closed

opened 2022-01-18 16:32:41 +00:00 by quentin · 1 comment

quentin commented

2022-01-18 16:32:41 +00:00

Owner

The doc says we (silently) overwrite:

If you upload a new part using the same part number that was used with a previous part, the previously uploaded part is overwritten.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_UploadPart.html

We fail with BadRequest:

	// Check part hasn't already been uploaded
	if let Some(v) = version {
		if v.has_part_number(part_number) {
			return Err(Error::BadRequest(format!(
				"Part number {} has already been uploaded",
				part_number
			)));
		}
	}

https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/api/s3_put.rs#L452-L460

The doc says we (silently) overwrite: > If you upload a new part using the same part number that was used with a previous part, the previously uploaded part is overwritten. https://docs.aws.amazon.com/AmazonS3/latest/API/API_UploadPart.html We fail with BadRequest: ```rust // Check part hasn't already been uploaded if let Some(v) = version { if v.has_part_number(part_number) { return Err(Error::BadRequest(format!( "Part number {} has already been uploaded", part_number ))); } } ``` https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/api/s3_put.rs#L452-L460