S3API - PUT - Checksum handling is broken #20
quentin
commented 2020-11-21 19:37:10 +00:00
Owner
- SHA256 and MD5 are not checked for files < 3Ko, problem occurs here
- MD5 check always fails as the MD5 string in the header is encoded in base64 but Rust produces an hexadecimal encoded MD5 sum. problem occurs here
1. SHA256 and MD5 are not checked for files < 3Ko, [problem occurs here](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/commit/b3814b15ccc233d7c4233b43816cce20db278f17/src/api/s3_put.rs#L48-L64)
2. MD5 check always fails as the MD5 string in the header is encoded in base64 but Rust produces an hexadecimal encoded MD5 sum. [problem occurs here](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/commit/b3814b15ccc233d7c4233b43816cce20db278f17/src/api/s3_put.rs#L94)
quentin
referenced a pull request that will close this issue 2020-11-22 10:06:18 +00:00
Fix checksum handling #21
lx
closed this issue 2020-11-22 14:29:06 +00:00
Labels
No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
No Milestone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#20
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?