S3API - PUT - Checksum handling is broken #20

New issue

Closed

opened 2020-11-21 19:37:10 +00:00 by quentin · 0 comments

quentin commented

2020-11-21 19:37:10 +00:00

Owner

SHA256 and MD5 are not checked for files < 3Ko, problem occurs here
MD5 check always fails as the MD5 string in the header is encoded in base64 but Rust produces an hexadecimal encoded MD5 sum. problem occurs here

1. SHA256 and MD5 are not checked for files < 3Ko, [problem occurs here](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/commit/b3814b15ccc233d7c4233b43816cce20db278f17/src/api/s3_put.rs#L48-L64) 2. MD5 check always fails as the MD5 string in the header is encoded in base64 but Rust produces an hexadecimal encoded MD5 sum. [problem occurs here](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/commit/b3814b15ccc233d7c4233b43816cce20db278f17/src/api/s3_put.rs#L94)