Enforce a protocol version check #206

New Issue

Closed

opened 2022-01-26 13:50:26 +00:00 by quentin · 2 comments

quentin commented

2022-01-26 13:50:26 +00:00

Owner

Could we start by adding a protocol check that prevent communications with nodes of a different version? Something very basic, it could be an header on all packets with a version number.

It is important because if garage is packaged in a distribution, from my experience with GlusterFS, it is very easy to have mismatching version simply by running a apt-get upgrade.

We discussed a lot about facilitating cluster migrations and behavior with different versions. The reality now is, often to work, we must have all nodes at the exact same version. And we do not document when it is not the case. Could we start by adding a protocol check that prevent communications with nodes of a different version? Something very basic, it could be an header on all packets with a version number. It is important because if garage is packaged in a distribution, from my experience with GlusterFS, it is very easy to have mismatching version simply by running a `apt-get upgrade`.

quentin added the

Correctness

label 2022-01-26 13:50:26 +00:00

quentin commented

2022-01-27 10:26:01 +00:00

Author

Owner

Trinity's idea: RPC secret could be a hash of the user provided value and the version. We should adapt the error message to say that's either an error with the secret or a mismatching version