Add support for listening on unix sockets #253

New Issue

Closed

opened 2022-02-25 22:05:55 +00:00 by devnode · 2 comments

devnode commented

2022-02-25 22:05:55 +00:00

972426cee1

2/3rds of the work is already done. RPC is where I had to stop as I was running out of time and rust skills, haha...

The one thing that may need to change is parsing the RemoteAddr/RealIP from the HTTP headers if you want accurate logging from withing the service handlers.

I'll have time next week to continue working on it but if someone more knowledgeable with the code base (and rust) can get it working in a few lines, it'll probably save me a few hours and a headache or two.

Cheers,
Tom

https://git.deuxfleurs.fr/devnode/garage-unix-socket/commit/972426cee19cf1d4c6ef4e11eb03955068c08134 2/3rds of the work is already done. RPC is where I had to stop as I was running out of time and rust skills, haha... The one thing that may need to change is parsing the RemoteAddr/RealIP from the HTTP headers if you want accurate logging from withing the service handlers. I'll have time next week to continue working on it but if someone more knowledgeable with the code base (and rust) can get it working in a few lines, it'll probably save me a few hours and a headache or two. Cheers, Tom

lx commented

2022-03-15 10:05:52 +00:00

Owner

Hi @devnode, could you open a pull request for your work? You can mark it with the WIP: prefix to indicate that the work is not finished yet.

I'm closing this issue for now as this is not the correct place to discuss it, but we're definitely interested in having your work in Garage once it is complete.

Hi @devnode, could you open a pull request for your work? You can mark it with the `WIP:` prefix to indicate that the work is not finished yet. I'm closing this issue for now as this is not the correct place to discuss it, but we're definitely interested in having your work in Garage once it is complete.

lx closed this issue

2022-03-15 10:05:52 +00:00

foxpro commented

2023-08-17 09:57:04 +00:00

@lx hey, can we open this? I would like to have ability to connect via unix domain socketz, especially for web api. It' very convinient as it doesn't reserve port