x-amz-checksum-algorithm for multipart uploads #347

New issue

Closed

opened 2022-08-02 20:06:39 +00:00 by schmitch · 1 comment

schmitch commented

2022-08-02 20:06:39 +00:00

amazon supports setting a x-amz-checksum-algorithm header in the initial multipart upload: https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateMultipartUpload.html#API_CreateMultipartUpload_ResponseSyntax

this can later than be used to validate the checksum of the completed object:
https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html#API_CompleteMultipartUpload_RequestSyntax

this would be great to add to garage since it would simplify multipart upload validation, for users. on the aws side it will actually fail if the checksum does not match.

(btw. minio does not have this feature yet and it is relativly new)

amazon supports setting a `x-amz-checksum-algorithm` header in the initial multipart upload: https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateMultipartUpload.html#API_CreateMultipartUpload_ResponseSyntax this can later than be used to validate the checksum of the completed object: https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html#API_CompleteMultipartUpload_RequestSyntax this would be great to add to garage since it would simplify multipart upload validation, for users. on the aws side it will actually fail if the checksum does not match. (btw. minio does not have this feature yet and it is relativly new)

quentin added the

scope

s3-api

label 2022-08-03 14:11:35 +00:00

quentin added the

action

for-newcomers

label 2022-08-03 14:13:48 +00:00

quentin commented

2022-08-03 14:15:09 +00:00

Owner

Also, please note that Garage Multipart Implementation has some limitations compared to AWS one described in #204, so if you heavily rely on this feature, you should be aware of this.

Thanks for your suggestion, I added some tags to your issue to track it. We are currently working on Garage performances so we don't plan to work on it soon, but at the same time, it might be an interesting first contribution for newcomers :-) Also, please note that Garage Multipart Implementation has some limitations compared to AWS one described in #204, so if you heavily rely on this feature, you should be aware of this.

👍 1