Unwanted println! #358

New Issue

Closed

opened 2022-08-11 18:04:20 +00:00 by quentin · 0 comments

quentin commented

2022-08-11 18:04:20 +00:00

Owner

When running some tests on garage, a mysterious line pops each time I create a bucket:

 Element { tag_name: {http://s3.amazonaws.com/doc/2006-03-01/}LocationConstraint, attributes: [], namespaces: [Namespace { name: None, uri: "http://s3.amazonaws.com/doc/2006-03-01/" }] }

A quick look at our source code highlighted some unwanted println:

src/rpc/kubernetes.rs:59:		println!("Found Pod: {:?}", node.metadata.name);
src/api/s3/bucket.rs:298:		println!("{:?}", item);
src/api/s3/copy.rs:657:		println!("{}", to_xml_with_header(&v)?);

The first one should be replaced to use the Rust logger at the info level.
The other ones might be removed or logged at the trace level

When running some tests on garage, a mysterious line pops each time I create a bucket: ``` Element { tag_name: {http://s3.amazonaws.com/doc/2006-03-01/}LocationConstraint, attributes: [], namespaces: [Namespace { name: None, uri: "http://s3.amazonaws.com/doc/2006-03-01/" }] } ``` A quick look at our source code highlighted some unwanted println: ``` src/rpc/kubernetes.rs:59: println!("Found Pod: {:?}", node.metadata.name); src/api/s3/bucket.rs:298: println!("{:?}", item); src/api/s3/copy.rs:657: println!("{}", to_xml_with_header(&v)?); ``` The first one should be replaced to use the Rust logger at the info level. The other ones might be removed or logged at the trace level