Race condition leads to data deletion

lx commented

2021-03-15 14:12:56 +00:00

Owner

WARNING TO 0.1.x USERS: the S3 Copy call will delete your data if the source and the destination are the same object. This is being worked on and will be fixed in 0.2

Probably fixed in 097c339d98
Write regression test

WARNING TO `0.1.x` USERS: the S3 Copy call will delete your data if the source and the destination are the same object. This is being worked on and will be fixed in `0.2` - [x] Probably fixed in 097c339d98 - [ ] Write regression test

lx added this to the 0.2 milestone 2021-03-15 14:12:56 +00:00

lx added the

Bug

Critical

labels 2021-03-15 14:12:56 +00:00

lx commented

2021-03-15 14:27:10 +00:00

Author

Owner

WIP 097c339d98

WIP 097c339d98

lx commented

2021-04-14 21:39:56 +00:00

Author

Owner

The scenario that caused this error was in the CopyObject call when the source and the destination had the same path (i.e. the destination overwrites the source, e.g. to change some metadata info). Basically there was a race condition in the refcount for blocks leading to rc=0, blocks get deleted, rc goes back to 1, blocks are nowhere to be found.

👍 1 🚀 1

lx modified the milestone from 0.2 to v0.5.0

2021-09-08 16:12:59 +00:00

lx commented

2021-09-08 16:13:38 +00:00

Author

Owner

TODO for NGI Milestone 1: add a 24-hour delay before deleting anything on disk (table GC and block deletion)

lx referenced this issue

2021-09-08 16:16:13 +00:00

Code refactoring and improvement for NGI Milestone 1 #104

~~lx referenced this issue 2021-10-28 15:47:47 +00:00~~