Race condition leads to data deletion #39

Closed
opened 2 years ago by lx · 3 comments
lx commented 2 years ago
Owner

WARNING TO 0.1.x USERS: the S3 Copy call will delete your data if the source and the destination are the same object. This is being worked on and will be fixed in 0.2

  • Probably fixed in 097c339d98
  • Write regression test
WARNING TO `0.1.x` USERS: the S3 Copy call will delete your data if the source and the destination are the same object. This is being worked on and will be fixed in `0.2` - [x] Probably fixed in 097c339d98 - [ ] Write regression test
lx added this to the 0.2 milestone 2 years ago
lx added the
Bug
Critical
labels 2 years ago
lx commented 2 years ago
Poster
Owner
WIP 097c339d98
lx commented 1 year ago
Poster
Owner

The scenario that caused this error was in the CopyObject call when the source and the destination had the same path (i.e. the destination overwrites the source, e.g. to change some metadata info). Basically there was a race condition in the refcount for blocks leading to rc=0, blocks get deleted, rc goes back to 1, blocks are nowhere to be found.

The scenario that caused this error was in the CopyObject call when the source and the destination had the same path (i.e. the destination overwrites the source, e.g. to change some metadata info). Basically there was a race condition in the refcount for blocks leading to rc=0, blocks get deleted, rc goes back to 1, blocks are nowhere to be found.
lx modified the milestone from 0.2 to v0.5.0 1 year ago
lx commented 1 year ago
Poster
Owner

TODO for NGI Milestone 1: add a 24-hour delay before deleting anything on disk (table GC and block deletion)

TODO for NGI Milestone 1: add a 24-hour delay before deleting anything on disk (table GC and block deletion)
lx closed this issue 11 months ago
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.