Check uploaded data's MD5 sum against Content-MD5 header #4

New issue

Closed

opened 2020-07-13 14:57:05 +00:00 by lx · 1 comment

lx commented

2020-07-13 14:57:05 +00:00

Owner

Garage currently does not implement checking of the MD5 sum of the uploaded data, which should match the Content-MD5 header. Should be implemented.

This should be done for:

PutObject
UploadPart
anything else?

We should make sure that we implement this well enough so that the following is also verified: if a request to put an object contains a MD5 sum and the MD5 sum is part of the authenticated/signed request (AWS signatures v4 protocol), then we know that the data itself is authenticated properly by the signing key.

Garage currently does not implement checking of the MD5 sum of the uploaded data, which should match the Content-MD5 header. Should be implemented. This should be done for: - [x] PutObject - [x] UploadPart - [ ] anything else? We should make sure that we implement this well enough so that the following is also verified: if a request to put an object contains a MD5 sum and the MD5 sum is part of the authenticated/signed request (AWS signatures v4 protocol), then we know that the data itself is authenticated properly by the signing key.