Use status code 204 No Content for empty responses #403
No reviewers
Labels
No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#403
Loading…
Reference in a new issue
No description provided.
Delete branch "tobikris/garage:http-no-content"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I picked the starter issue #376 to get familiar with the repo.
I successfully ran the smoke-tests (except winscp because I am running on Linux).
When replacing one occurence of an empty body and status 200 with status 204 the minio tests fail - I don't understand why this is the case but left it at 200 therefore.
2c3dab7716
to9b57d5b4c2
Sorry, I think the issue description was quite misleading, but in fact S3 API endpoints are NOT concerned by this issue and should NOT be changed.
Issue #376 concerns only the Admin API, which is an API that we designed ourselves, and where we can decide freely what HTTP return codes we use. For the S3 API we have no freedom, as we have to mimic exactly what AWS does. As you saw, changing the return codes on S3 endpoints causes tests to fail, so they should stay as they are because that's the correct behavior to conform to the S3 spec.
9b57d5b4c2
to1e3369820e
1e3369820e
to12b058e073
12b058e073
to7865003323
Ok, I changed the PR to only touch the admin and k2v API. However, the CI seems to be broken currently :(
Ci is now fixed, pesky issue with a runner not having access to Gitea
Thanks for the PR, LGTM.
Do you think you could also update the documentation for the admin api and K2V api to indicate the new return status codes? They are respectively in
doc/book/reference-manual/admin-api.md
anddoc/drafts/k2v-spec.md
I have added the documentation changes about k2v. The admin-api docs however do not contain references to specific return codes. Is it therefore ok like this?
Indeed, there is nothing to update in the admin API documentation. Thanks for the work!
Fix #376
ping @quentin: your openapi specs will need updating