Deuxfleurs
/
garage
41
37
Fork 55
Code Issues 70 Pull Requests 6 Releases 29 Wiki Activity

helm: ingress improvements #422

Closed
patrickjahns wants to merge 3 commits from patrickjahns/garage:helm-refactor-ingress into main
pull from: patrickjahns/garage:helm-refactor-ingress
merge into: Deuxfleurs:main
Conversation 3 Commits 3 Files Changed 3 +17 -6
patrickjahns commented 2022-11-16 11:29:33 +00:00
Contributor
Copy Link

As discussed in the chat yesterday, I want to propose to disable the ingress per default.

The motivation behind this change is, that per default the ingress is "misconfigured" meaning it can not work with the default values and requires a user of the chart to add additional configuration. When installing the chart per default, I would not expect to already expose garage publicly without my explicit configuration to do so

Commenting the ingressClass resource also allows for relying only on annotations - otherwise the ingressClass would be always set to nginx or require a user to override it with ingressClass: null

A small change on top, I've added the ability to specify user defined labels per ingress

As discussed in the chat yesterday, I want to propose to disable the ingress per default. The motivation behind this change is, that per default the ingress is "misconfigured" meaning it can not work with the default values and requires a user of the chart to add additional configuration. When installing the chart per default, I would not expect to already expose garage publicly without my explicit configuration to do so Commenting the `ingressClass` resource also allows for relying only on annotations - otherwise the ingressClass would be always set to nginx or require a user to override it with `ingressClass: null` A small change on top, I've added the ability to specify user defined labels per ingress
patrickjahns added 3 commits 2022-11-16 11:29:34 +00:00
b31d9a6be0
refactor(helm): disable the ingress per default 
The default values forces people to create an ingress resources,
where per default an ingress is not necessary to start garage.

If someone wants to utilize an ingress, he would need to define
the values for the ingress either way, so enabling the ingress
explicitly makes more sense, then requiring it to be disabled per default
continuous-integration/drone/pr Build is passing Details
1dd3869199
chore(helm): bump chart number
lx commented 2022-11-16 12:37:42 +00:00
Owner
Copy Link

@maximilien can you review this?

@maximilien can you review this?
maximilien self-assigned this 2022-11-18 09:21:29 +00:00
kaiyou commented 2022-11-18 19:09:26 +00:00
Contributor
Copy Link

This compiles properly and should deploy fine although I did not run end to end tests.

I agree those changes are welcome, especially diabling the default ingress class, which inteferes with many setups.

This compiles properly and should deploy fine although I did not run end to end tests. I agree those changes are welcome, especially diabling the default ingress class, which inteferes with many setups.
maximilien requested review from maximilien 2022-12-11 23:12:21 +00:00
maximilien approved these changes 2022-12-11 23:13:03 +00:00
maximilien commented 2022-12-12 00:03:43 +00:00
Owner
Copy Link

Sorry @patrickjahns I had to 'manually' merge this PR because I tried to rebase it though the interface and Gitea got itself stuck on the rebase hook, because of a somewhat cryptic incompatibility issue between musl/alpine and docker (see here the notes about faccessat2). The commits retained your name, but the end result ended up under mine. Please acccepts my appologies for that, next time I'll remember to use Co-authored-by:...

Sorry @patrickjahns I had to 'manually' merge this PR because I tried to rebase it though the interface and Gitea got itself stuck on the rebase hook, because of a somewhat cryptic incompatibility issue between musl/alpine and docker (see [here](https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0) the notes about `faccessat2`). The commits retained your name, but [the end result](https://git.deuxfleurs.fr/Deuxfleurs/garage/commit/980572a8872c56ea9572ff03579ebb9a65013775) ended up under mine. Please acccepts my appologies for that, next time I'll remember to use `Co-authored-by:`...
👍 1
maximilien closed this pull request 2022-12-12 00:04:00 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
maximilien
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
maximilien
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#422
No description provided.
Delete Branch "patrickjahns/garage:helm-refactor-ingress"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?