Deuxfleurs/garage
41
56
Fork 73
Code Issues 99 Pull requests 14 Releases 30 Wiki Activity

helm: ingress improvements #422

Closed
patrickjahns wants to merge 3 commits from patrickjahns/garage:helm-refactor-ingress into main
pull from: patrickjahns/garage:helm-refactor-ingress
merge into: Deuxfleurs:main
Conversation 3 Commits 3 Files changed 3 +17 -6
patrickjahns commented 2022-11-16 11:29:33 +00:00
Contributor
Copy link

As discussed in the chat yesterday, I want to propose to disable the ingress per default.

The motivation behind this change is, that per default the ingress is "misconfigured" meaning it can not work with the default values and requires a user of the chart to add additional configuration. When installing the chart per default, I would not expect to already expose garage publicly without my explicit configuration to do so

Commenting the ingressClass resource also allows for relying only on annotations - otherwise the ingressClass would be always set to nginx or require a user to override it with ingressClass: null

A small change on top, I've added the ability to specify user defined labels per ingress

As discussed in the chat yesterday, I want to propose to disable the ingress per default. The motivation behind this change is, that per default the ingress is "misconfigured" meaning it can not work with the default values and requires a user of the chart to add additional configuration. When installing the chart per default, I would not expect to already expose garage publicly without my explicit configuration to do so Commenting the `ingressClass` resource also allows for relying only on annotations - otherwise the ingressClass would be always set to nginx or require a user to override it with `ingressClass: null` A small change on top, I've added the ability to specify user defined labels per ingress
patrickjahns added 3 commits 2022-11-16 11:29:34 +00:00 
The default values forces people to create an ingress resources,
where per default an ingress is not necessary to start garage.

If someone wants to utilize an ingress, he would need to define
the values for the ingress either way, so enabling the ingress
explicitly makes more sense, then requiring it to be disabled per default
chore(helm): bump chart number
All checks were successful
continuous-integration/drone/pr Build is passing
Details
1dd3869199
lx commented 2022-11-16 12:37:42 +00:00
Owner
Copy link

@maximilien can you review this?

@maximilien can you review this?
maximilien self-assigned this 2022-11-18 09:21:29 +00:00
kaiyou commented 2022-11-18 19:09:26 +00:00
Contributor
Copy link

This compiles properly and should deploy fine although I did not run end to end tests.

I agree those changes are welcome, especially diabling the default ingress class, which inteferes with many setups.

This compiles properly and should deploy fine although I did not run end to end tests. I agree those changes are welcome, especially diabling the default ingress class, which inteferes with many setups.
maximilien requested review from maximilien 2022-12-11 23:12:21 +00:00
maximilien approved these changes 2022-12-11 23:13:03 +00:00
maximilien commented 2022-12-12 00:03:43 +00:00
Owner
Copy link

Sorry @patrickjahns I had to 'manually' merge this PR because I tried to rebase it though the interface and Gitea got itself stuck on the rebase hook, because of a somewhat cryptic incompatibility issue between musl/alpine and docker (see here the notes about faccessat2). The commits retained your name, but the end result ended up under mine. Please acccepts my appologies for that, next time I'll remember to use Co-authored-by:...

Sorry @patrickjahns I had to 'manually' merge this PR because I tried to rebase it though the interface and Gitea got itself stuck on the rebase hook, because of a somewhat cryptic incompatibility issue between musl/alpine and docker (see [here](https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0) the notes about `faccessat2`). The commits retained your name, but [the end result](https://git.deuxfleurs.fr/Deuxfleurs/garage/commit/980572a8872c56ea9572ff03579ebb9a65013775) ended up under mine. Please acccepts my appologies for that, next time I'll remember to use `Co-authored-by:`...
👍 1
maximilien closed this pull request 2022-12-12 00:04:00 +00:00
Some checks are pending
continuous-integration/drone/pr Build is passing
Details
ci/woodpecker/pr/debug
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
maximilien
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
maximilien
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#422
No description provided.
Delete branch "patrickjahns/garage:helm-refactor-ingress"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?