Incompatibility with rusty-s3 #442

Closed
opened 2022-12-08 15:54:29 +00:00 by asonix · 5 comments
Contributor

I should say that I'm not sure if garage or if rusty-s3 is in the wrong, here, but I'm opening this issue first with Garage since my project works fine with minio

Garage seems to expect that a "keyword" in the query string, i.e. the term that identifies the kind of request, should have no associated value. rusty-s3 doesn't agree, and sets the "keyword" for the query string to have a value of "1"

Relevent lines:

Since garage does not expect uploads to have a value of 1, CreateMultipartRequest fails validation with a 400 error.

If this is actually a problem in rusty-s3, I will open an issue there.

I should say that I'm not sure if `garage` or if `rusty-s3` is in the wrong, here, but I'm opening this issue first with Garage since my project works fine with `minio` Garage seems to expect that a "keyword" in the query string, i.e. the term that identifies the kind of request, should have no associated value. rusty-s3 doesn't agree, and sets the "keyword" for the query string to have a value of "1" Relevent lines: - https://github.com/paolobarbolini/rusty-s3/blob/main/src/actions/multipart_upload/create.rs#L81 - https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/api/router_macros.rs#L174 Since garage does not expect `uploads` to have a value of `1`, `CreateMultipartRequest` fails validation with a 400 error. If this is actually a problem in rusty-s3, I will open an issue there.
lx added the
S3 Compatibility
label 2022-12-12 09:53:44 +00:00
Owner

If it works on other S3 implementations (Minio, Amazon), then this is definitely Garage's fault.

If it works on other S3 implementations (Minio, Amazon), then this is definitely Garage's fault.
Owner

@asonix do you have a simple test code for this, or are you able to check easily if #446 fixes this?

@asonix do you have a simple test code for this, or are you able to check easily if #446 fixes this?
Author
Contributor

I'll get this tested later today, thanks!

I'll get this tested later today, thanks!
Author
Contributor

Just took a look. Works great!

Just took a look. Works great!
Owner

Great, thanks!

Great, thanks!
lx closed this issue 2022-12-15 08:40:26 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#442
No description provided.