improvements to CLI and new debug features #448

Merged

lx merged 9 commits from cli-improvements into main 2023-01-02 12:42:24 +00:00

Conversation 1 Commits 9 Files Changed 24 +725 -190

lx commented 2022-12-13 10:50:58 +00:00

Owner

Copy Link

CLI UX:

• Remove info and warning messages before the CLI does its thing, including when rpc_public_addr is not set
• Worker list is an actual table now
• New command worker info
• Rename resync-n-workers into resync-worker-count
• Improve status command with more info, including info from scrub/resync/etc - or put some of that in garage stats
• Something about paused scrubs resuming automatically / or don't resume automatically but show a warning everywhere during duration of pause
• prettier table in garage stats
• more things in garage stats

CLI debug features:

• garage block list-errors -> table of resync errored blocks, with (hash, rc, number of errors, time of last error/time of retry)
• garage block info <block> -> info about any block, including all objects that use it
• garage block retry-now [<hash> | ---all] -> retry resync of a block in errored status
• garage block purge <block>... -> delete all objects that reference a lost block

Non-CLI related:

• resync worker, use error! instead of warn! for "error when resyncing" block messages
• table lengths in metrics, if possible to have them fast (i.e. not with Sled)

CLI UX: - [x] Remove info and warning messages before the CLI does its thing, including when rpc_public_addr is not set - [x] Worker list is an actual table now - [x] New command `worker info` - [x] Rename `resync-n-workers` into `resync-worker-count` - [ ] Improve status command with more info, including info from scrub/resync/etc - or put some of that in garage stats - [ ] Something about paused scrubs resuming automatically / or don't resume automatically but show a warning everywhere during duration of pause - [x] prettier table in `garage stats` - [ ] more things in `garage stats` CLI debug features: - [x] `garage block list-errors` -> table of resync errored blocks, with (hash, rc, number of errors, time of last error/time of retry) - [x] `garage block info <block>` -> info about any block, including all objects that use it - [x] `garage block retry-now [<hash> | ---all]` -> retry resync of a block in errored status - [x] `garage block purge <block>...` -> delete all objects that reference a lost block Non-CLI related: - [x] resync worker, use `error!` instead of `warn!` for "error when resyncing" block messages - [x] table lengths in metrics, if possible to have them fast (i.e. not with Sled)

lx added 2 commits 2022-12-13 10:50:58 +00:00

de9d6cddf7

Prettier worker list table; remove useless CLI log messages

a51e8d94c6

cli: rename resync-n-workers into resync-worker-count

lx added 1 commit 2022-12-13 11:24:46 +00:00

9d82196945

cli: new worker info command

lx added 1 commit 2022-12-13 13:24:01 +00:00

687660b27f

Implement `block list-errors` and `block info`

lx added 1 commit 2022-12-13 14:02:58 +00:00

d7f90cabb0

Implement `block retry-now` and `block purge`

lx added 1 commit 2022-12-13 14:43:35 +00:00

d6040e32a6

cli: prettier table in garage stats

lx added 1 commit 2022-12-13 14:46:24 +00:00

f8d5409894

cli: more info displayed on error in garage stats

lx added 1 commit 2022-12-13 14:54:19 +00:00

041b60ed1d

Add block.rc_size, table.size and table.merkle_tree_size metrics

lx added 1 commit 2022-12-13 15:18:08 +00:00

d1279e04f3

Fix error messages

kaiyou commented 2022-12-25 12:36:58 +00:00

Contributor

Copy Link

Quick feedback on the debug features (block list-errors & block info) and tabular display: been using on a production cluster them for debugging for the past week, with zero issue.

Quick feedback on the debug features (block list-errors & block info) and tabular display: been using on a production cluster them for debugging for the past week, with zero issue.

lx changed title from WIP: improvements to CLI and new debug features to improvements to CLI and new debug features 2023-01-02 12:42:13 +00:00

lx merged commit 7f7d53cfa9 into main 2023-01-02 12:42:24 +00:00

lx referenced this issue from a commit 2023-01-02 12:42:25 +00:00

Merge pull request 'improvements to CLI and new debug features' (#448) from cli-improvements into main

lx deleted branch cli-improvements 2023-01-02 12:42:25 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

AdminAPI

Issues concerning the administration API

  

Bug

  

Check AWS

The behaviour should be checked against AWS S3

  

CI

Issues with Nix, Drone, Rust Compiler, etc.

  

Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  

Critical

  

Documentation

  

Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  

Improvement

  

Low priority

For issues that we don't want to spend time on until made absolutely necessary

  

Newcomer

A bug that should be newcomer friendly.

  

Performance

  

S3 Compatibility

  

Testing

  

Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label

AdminAPI

Bug

Check AWS

CI

Correctness

Critical

Documentation

Ideas

Improvement

Low priority

Newcomer

Performance

S3 Compatibility

Testing

Usability

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#448

No description provided.