Deuxfleurs/garage
41
56
Fork 73
Code Issues 99 Pull requests 14 Releases 30 Wiki Activity

Some improvements to Garage internals #451

Merged
lx merged 14 commits from internals-rework into main 2023-01-03 11:37:32 +00:00
Conversation 0 Commits 14 Files changed 27 +442 -559
lx commented 2022-12-14 11:01:37 +00:00
Owner
Copy link
  • Proper queueing for delayed inserts, now persisted to disk
  • Launch background workers in separate step, so that it is not done for offline repair
  • Get rid of background job worker and one-shot background spawn functions
  • Simplified worker exit logic, make it more aggressive (expect all queues to be persisted)
  • Online repair workers: retry on error
  • Small refactorings
- [x] Proper queueing for delayed inserts, now persisted to disk - [x] Launch background workers in separate step, so that it is not done for offline repair - [x] Get rid of background job worker and one-shot background spawn functions - [x] Simplified worker exit logic, make it more aggressive (expect all queues to be persisted) - [x] Online repair workers: retry on error - [x] Small refactorings
lx added 2 commits 2022-12-14 11:01:37 +00:00
Small refactor of tables internals
Some checks failed
continuous-integration/drone/push Build is failing
Details
f8e528c15d
Proper queueing for delayed inserts, now backed to disk
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
83c8467e23
lx added 2 commits 2022-12-14 11:51:49 +00:00
Refactor background runner and get rid of job worker
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
d56c472712
lx added 1 commit 2022-12-14 11:57:46 +00:00
Improve error message on rpc connection failure
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
a19bfef508
lx added 1 commit 2022-12-14 11:58:34 +00:00
Update cargo.nix
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details
0d6b05bb6c
lx added 1 commit 2022-12-14 12:54:34 +00:00
Add missing notify
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
d4af27f920
lx added 1 commit 2022-12-14 14:25:46 +00:00
Simplified and more aggressive worker exit logic
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
dfc131850a
lx added 1 commit 2022-12-14 15:08:27 +00:00
Get rid of background::spawn
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
510b620108
lx added 1 commit 2022-12-14 15:11:29 +00:00
better error message handling
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
e6f14ab5cf
lx added 1 commit 2022-12-14 15:17:04 +00:00
factorize
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
13c8662126
lx added 1 commit 2022-12-14 15:31:51 +00:00
online repair workers: retry on error
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
1fcd0b371b
lx closed this pull request 2023-01-02 12:42:25 +00:00
lx reopened this pull request 2023-01-02 12:44:03 +00:00
lx changed target branch from cli-improvements to main 2023-01-02 12:44:11 +00:00
lx added 1 commit 2023-01-02 12:50:51 +00:00
cargo fmt
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
6b857a9b8c
lx added 1 commit 2023-01-02 14:07:50 +00:00
Merge branch 'main' into internals-rework
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
939a6d67e8
lx changed title from WIP: Some improvements to Garage internals to Some improvements to Garage internals 2023-01-03 11:37:24 +00:00
lx merged commit 582b076179 into main 2023-01-03 11:37:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#451
No description provided.
Delete branch "internals-rework"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?