Deuxfleurs
/
garage
41
37
Fork 55
Code Issues 70 Pull Requests 6 Releases 29 Wiki Activity

Changed all instances of 'key new' to 'key create' to make it the same as the bucket commands. #459

Merged
lx merged 1 commits from jpds/garage:key-create-standardize into next 2023-01-04 10:35:50 +00:00
Conversation 3 Commits 1 Files Changed 8 +14 -15
jpds commented 2023-01-02 13:39:24 +00:00
Contributor
Copy Link
No description provided.
lx commented 2023-01-02 13:50:09 +00:00
Owner
Copy Link

LGTM, however automated tests need fixing.

This can be integrated in v0.9, we won't integrate it in the v0.8.x branch as it is a potentially breaking change for our users.

LGTM, however automated tests need fixing. This can be integrated in v0.9, we won't integrate it in the v0.8.x branch as it is a potentially breaking change for our users.
jpds force-pushed key-create-standardize from 49e6773bcd to b2af8ec7e8 2023-01-02 14:01:22 +00:00 Compare
jpds commented 2023-01-02 14:03:18 +00:00
Author
Contributor
Copy Link

@lx The tests appear to be broken even on main branch - I've changed the one instance I found of key new.

@lx The tests appear to be broken even on `main` branch - I've changed the one instance I found of `key new`.
lx commented 2023-01-02 14:05:46 +00:00
Owner
Copy Link

This one also needs fixing: https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/script/dev-bucket.sh#L13

Then I think we will be good

This one also needs fixing: https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/script/dev-bucket.sh#L13 Then I think we will be good
👍 1
jpds force-pushed key-create-standardize from b2af8ec7e8 to 55be8b0f33 2023-01-02 14:10:15 +00:00 Compare
jpds force-pushed key-create-standardize from 55be8b0f33 to 8be862aa19 2023-01-03 11:11:56 +00:00 Compare
lx changed target branch from main to next 2023-01-04 10:30:24 +00:00
lx merged commit 80e4abb98d into next 2023-01-04 10:35:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#459
No description provided.
Delete Branch "jpds/garage:key-create-standardize"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?