Deuxfleurs/garage
41
56
Fork 73
Code Issues 103 Pull requests 14 Releases 30 Wiki Activity

PutObject: better cleanup when request is interrupted in the middle #462

Merged
lx merged 2 commits from interrupted-cleanup into main 2023-01-04 14:43:45 +00:00
Conversation 0 Commits 2 Files changed 2 +91 -38
lx commented 2023-01-03 15:49:31 +00:00
Owner
Copy link
  • PutObject: if request is canceled, an upload in progress is marked as Aborted in all cases using Drop
  • Block manager: if a block save request is canceled, the .tmp file is removed if it existed

For multipart-related calls:

  • Given that Garage does not implement the full multipart upload, i.e. it does not support retrying the upload of a single part (which defeats the purpose of multipart upload, ik, we'll fix it for v0.9), we have nothing better to do than abort the entire uplaod as soon as the upload of one part fails
  • However, marking the upload as aborted automatically in that case kind of violates the S3 spec as well
  • In conclusion, do we prefer exposing to the user uploads in progress which cannot be continued (the only choice is to abort them explicitly), or exposing them to having their uploads marked aborted automatically?
- [x] PutObject: if request is canceled, an upload in progress is marked as Aborted in all cases using `Drop` - [x] Block manager: if a block save request is canceled, the `.tmp` file is removed if it existed For multipart-related calls: - Given that Garage does not implement the full multipart upload, i.e. it does not support retrying the upload of a single part (which defeats the purpose of multipart upload, ik, we'll fix it for v0.9), we have nothing better to do than abort the entire uplaod as soon as the upload of one part fails - However, marking the upload as aborted automatically in that case kind of violates the S3 spec as well - In conclusion, do we prefer exposing to the user uploads in progress which cannot be continued (the only choice is to abort them explicitly), or exposing them to having their uploads marked aborted automatically?
lx force-pushed interrupted-cleanup from cf06398e29 to 0650a43cf1 2023-01-03 16:05:25 +00:00 Compare
lx changed title from PutObject: better cleanup on Drop (incl. when request is interrupted in the middle) to PutObject: better cleanup when request is interrupted in the middle 2023-01-03 16:29:51 +00:00
lx force-pushed interrupted-cleanup from 908f24db76 to 936b6cb563 2023-01-03 16:34:32 +00:00 Compare
lx merged commit 02e8eb167e into main 2023-01-04 14:43:45 +00:00
lx deleted branch interrupted-cleanup 2023-01-04 14:43:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#462
No description provided.
Delete branch "interrupted-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?