Clearer error message when LMDB has oom error (fix #517) #519
No reviewers
Labels
No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Deuxfleurs/garage#519
Loading…
Reference in New Issue
No description provided.
Delete Branch "lmdb-oom-message"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I think that error is still not sufficient. It should tell the user how much is the minium it has to allocate for it to function properly.
If it's not known how much it needs, there is no way to actually make proper limits that would allow it.
If that virtual memory is not enough, then it would probably need optimization.
That's not how it works. LMDB needs to be able to map in RAM the entire file of the biggest possible database we want to support; concievably someone will someday use Garage with a metadata db bigger than 67GB. Currently the limit is set to 1TB (on 64-bit systems), we might raise it if needed but definitely not make it smaller. On 32-bit systems Garage tries to use a 1GB map size but it's wanky and LMDB should better be avoided on 32-bit systems.