Deuxfleurs/garage
44
56
Fork 73
Code Issues 100 Pull requests 14 Releases 30 Wiki Activity

rpc/system_metrics.rs: Added rustversion label to garage_build_info metric. #524

Merged
lx merged 5 commits from jpds/garage:rustversion-label into main 2023-03-13 15:46:49 +00:00
Conversation 5 Commits 5 Files changed 8 +28 -6
jpds commented 2023-03-10 11:44:42 +00:00
Contributor
Copy link
No description provided.
jpds force-pushed rustversion-label from 25e90d2bf9 to 531cd017ab 2023-03-10 11:48:40 +00:00 Compare
quentin commented 2023-03-10 12:23:09 +00:00
Owner
Copy link

Hi @jpds, thanks for your PR, can you elaborate a bit more around the use cases you see for it?

Hi @jpds, thanks for your PR, can you elaborate a bit more around the use cases you see for it?
jpds commented 2023-03-10 12:24:14 +00:00
Author
Contributor
Copy link

@quentin Knowing when to rebuild all the Rust binaries because of a vulnerability at the compiler level.

@quentin Knowing when to rebuild all the Rust binaries because of a vulnerability at the compiler level.
👍 1
quentin commented 2023-03-10 12:36:43 +00:00
Owner
Copy link

Makes sense. Before accepting it, I want to be sure that it does not break our NixOS-based build system, as you introduce a build.rs file. Otherwise, looks good to me.

Makes sense. Before accepting it, I want to be sure that it does not break our NixOS-based build system, as you introduce a build.rs file. Otherwise, looks good to me.
jpds commented 2023-03-10 13:53:09 +00:00
Author
Contributor
Copy link

Someone will need to push up a Cargo.nix change for the new package (which is why I allowed edits from maintainers) - but I think it should work fine after that.

Someone will need to push up a `Cargo.nix` change for the new package (which is why I allowed edits from maintainers) - but I think it should work fine after that.
lx requested changes 2023-03-10 14:05:08 +00:00
src/rpc/build.rs Outdated
@ -0,0 +1,8 @@
use rustc_version::version;
fn main() {
lx commented 2023-03-10 14:05:05 +00:00
Owner
Copy link

Can we move this to the garage_util crate, and make the rustc version available in the version module (as garage_util::version::rustc_version(), similarly to garage_util::version::garage_version())

This way we can also show the rustc version in garage stats (here) and in the status admin endpoint (here)

Can we move this to the `garage_util` crate, and make the rustc version available in the `version` module (as `garage_util::version::rustc_version()`, similarly to `garage_util::version::garage_version()`) This way we can also show the rustc version in `garage stats` ([here](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/garage/admin.rs#L821)) and in the status admin endpoint ([here](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/api/admin/cluster.rs#L21))
lx commented 2023-03-10 14:07:13 +00:00
Owner
Copy link

I can regen the cargo.nix file once the dependency on rustc_version is moved to the correct crate

I can regen the cargo.nix file once the dependency on rustc_version is moved to the correct crate
jpds marked this conversation as resolved
jpds force-pushed rustversion-label from 531cd017ab to 9ea154ae9c 2023-03-10 14:47:23 +00:00 Compare
lx added 1 commit 2023-03-10 17:15:17 +00:00
update cargo.nix
All checks were successful
continuous-integration/drone/pr Build is passing
Details
40fa1242f0
quentin commented 2023-03-13 09:52:47 +00:00
Owner
Copy link

I restarted the CI for the last commit.

It failed on thread 'k2v::poll::test_poll_range' panicked at 'Command exited with code 1: Could not get node ID', tests/common/ext/process.rs:46:31. Running the tests (with nix-build) on my computer worked. I suspect a race condition (we statically wait for only 2sec at garage startup).

I think I will open a separate PR to fix this issue, and the other one with the parallel tests. In the mean time, we should restart the CI and/or increase the duration in the fn setup() sleep, inside the src/garage/tests/common/garage.rs file.

I restarted the CI for the last commit. It failed on `thread 'k2v::poll::test_poll_range' panicked at 'Command exited with code 1: Could not get node ID', tests/common/ext/process.rs:46:31`. Running the tests (with nix-build) on my computer worked. I suspect a race condition (we statically wait for only 2sec at garage startup). I think I will open a separate PR to fix this issue, and the other one with the parallel tests. In the mean time, we should restart the CI and/or increase the duration in the `fn setup()` sleep, inside the `src/garage/tests/common/garage.rs` file.
lx added 1 commit 2023-03-13 15:14:19 +00:00
Merge branch 'main' into rustversion-label
All checks were successful
continuous-integration/drone/pr Build is passing
Details
f37ec584b6
lx merged commit 7fcc153e7c into main 2023-03-13 15:46:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lx
Labels
Clear labels   
action
check-aws
The behaviour should be checked against AWS S3

  
action
discussion-needed
We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  
action
for-external-contributors
Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  
action
for-newcomers
An issue that should be newcomer friendly.

  
action
more-info-needed
More information is needed to investigate this issue

  
action
need-funding
This issue represents lots of work, we need to find money to pay our core team work

  
action
triage-required
It's not very clear what we want to do with this issue yet, more thoughts is required

  
kind
correctness
Issues of theoretical correctness that may impact edge-case scenarios

  
kind
ideas
For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
kind
improvement
Feature requests that do not fall in other categories

  
kind
performance
Deceptive performance observed OR idea to improve performances

  
kind
testing
Functional tests, integration tests, Jepsen, etc.

  
kind
usability
Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  
kind
wrong-behavior
Unintended behavior

  
prio
critical
Could impact integrity or availability of production clusters

  
prio
low
For issues that we don't want to spend time on until made absolutely necessary

  
scope
admin-api
Issues concerning the administration API

  
scope
background-healing
Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  
scope
build
Issues with Nix, Drone, Rust Compiler, etc.

  
scope
documentation

  
scope
k8s
Kubernetes related, including Helm Charts

  
scope
layout
Linked to the cluster layout and storage management

  
scope
metadata
Metadata Engine (LMDB, sqlite, etc.)

  
scope
ops
Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  
scope
rpc
Linked to RPC

  
scope
s3-api
Related to the S3 API (especially compatibility issues).

  
scope
security
Cryptography-related, auth-related, authorization-related issues

  
scope
telemetry
OpenTelemetry (traces, metrics, etc.)

No labels
action
check-aws
action
discussion-needed
action
for-external-contributors
action
for-newcomers
action
more-info-needed
action
need-funding
action
triage-required
kind
correctness
kind
ideas
kind
improvement
kind
performance
kind
testing
kind
usability
kind
wrong-behavior
prio
critical
prio
low
scope
admin-api
scope
background-healing
scope
build
scope
documentation
scope
k8s
scope
layout
scope
metadata
scope
ops
scope
rpc
scope
s3-api
scope
security
scope
telemetry
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#524
No description provided.
Delete branch "jpds/garage:rustversion-label"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?