garage layout revert inconsistency #533

New Issue

Closed

opened 2023-03-16 11:11:32 +00:00 by withinboredom · 2 comments

withinboredom commented

2023-03-16 11:11:32 +00:00

Contributor

Output of garage layout revert:

Error: Internal error: 
Please pass the new layout version number to ensure that you are writing the correct version of the cluster layout.
To know the correct value of the new layout version, invoke `garage layout show` and review the proposed changes.

However, garage layout show doesn't show the new version when the new layout cannot be applied.

Calculating updated partition assignation, this may take some time...

Not enough nodes have an assigned role to maintain enough copies of data.
This new layout cannot yet be applied.

When running garage layout revert --help

garage-layout-revert v0.8.2
Revert staged changes to cluster layout

USAGE:
    garage layout revert [OPTIONS]

FLAGS:
    -h, --help    Prints help information

OPTIONS:
        --version <version>    Version number of old configuration to which to revert

It says to use the old version number, but this results in a failure:

garage layout revert --version 1                                                   Error: Internal error: Invalid new layout version

Then, after some guessing, I was able to figure out the correct version number.

Output of `garage layout revert`: ``` Error: Internal error: Please pass the new layout version number to ensure that you are writing the correct version of the cluster layout. To know the correct value of the new layout version, invoke `garage layout show` and review the proposed changes. ``` However, `garage layout show` doesn't show the new version when the new layout cannot be applied. ``` Calculating updated partition assignation, this may take some time... Not enough nodes have an assigned role to maintain enough copies of data. This new layout cannot yet be applied. ``` When running `garage layout revert --help` ``` garage-layout-revert v0.8.2 Revert staged changes to cluster layout USAGE: garage layout revert [OPTIONS] FLAGS: -h, --help Prints help information OPTIONS: --version <version> Version number of old configuration to which to revert ``` It says to use the **old** version number, but this results in a failure: ``` garage layout revert --version 1 Error: Internal error: Invalid new layout version ``` Then, after some guessing, I was able to figure out the correct version number.

quentin added the

Usability

label 2023-04-21 10:15:15 +00:00

quentin added the

Newcomer

label 2023-04-21 10:16:57 +00:00

quentin commented

2023-04-21 10:18:31 +00:00

Owner

Thanks for reporting this issue. Correct me if I am wrong, but the version number should be the current layout + 1 even when reverting. I tagged this issue as "newcomer" as it should not be too complicated to implement.