Deuxfleurs
/
garage
43
37
Fork 55
Code Issues 69 Pull Requests 4 Releases 29 Wiki Activity

Really allow to disable sled feature #563

Merged
lx merged 2 commits from jirutka/garage:workspace-deps into main 2023-05-09 09:08:35 +00:00
Conversation 2 Commits 2 Files Changed 10 +42 -32
jirutka commented 2023-05-07 16:23:33 +00:00
Contributor
Copy Link

The sled feature actually cannot be disabled for garage now because it’s enabled by default and default-enabled = false is not used for garage_db and garage_model in some crates in the dependency graph.

The `sled` feature actually cannot be disabled for `garage` now because it’s enabled by default and `default-enabled = false` is not used for garage_db and garage_model in some crates in the dependency graph.
jirutka commented 2023-05-07 16:25:15 +00:00
Author
Contributor
Copy Link

It seems that some tests don’t work when sled is disabled (and lmdb enabled).

It seems that some tests don’t work when `sled` is disabled (and `lmdb` enabled).
lx force-pushed workspace-deps from 5bf39460d9 to 75759a163c 2023-05-09 08:46:16 +00:00 Compare
lx commented 2023-05-09 09:08:32 +00:00
Owner
Copy Link

LGTM

LGTM
lx merged commit 5684e1990c into main 2023-05-09 09:08:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#563
No description provided.
Delete Branch "jirutka/garage:workspace-deps"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?