Deuxfleurs
/
garage
41
37
Fork 55
Code Issues 70 Pull Requests 6 Releases 29 Wiki Activity

block/manager.rs: Prioritize raw blocks when no compression configured #566

Merged
lx merged 1 commits from jpds/garage:skip-compressed-blocks-scrub-no-compression into main 2023-05-09 09:39:49 +00:00
Conversation 2 Commits 1 Files Changed 1 +25 -5
jpds commented 2023-05-08 18:15:38 +00:00
Contributor
Copy Link

During a node scrub - I noticed that garage was making a large number of syscalls for non-existent .zst files.

This adjusts is_block_compressed() to check if compression is enabled in the node configuration, and if not - it instead checks for the raw blocks first.

During a node scrub - I noticed that garage was making a large number of syscalls for non-existent `.zst` files. This adjusts `is_block_compressed()` to check if compression is enabled in the node configuration, and if not - it instead checks for the raw blocks first.
jpds force-pushed skip-compressed-blocks-scrub-no-compression from 0961b555e3 to c9f56ba97c 2023-05-08 18:37:38 +00:00 Compare
jpds force-pushed skip-compressed-blocks-scrub-no-compression from c9f56ba97c to 94470d5668 2023-05-08 19:28:14 +00:00 Compare
lx closed this pull request 2023-05-09 09:12:56 +00:00
lx reopened this pull request 2023-05-09 09:13:30 +00:00
lx commented 2023-05-09 09:13:43 +00:00
Owner
Copy Link

Sorry, ignore my previous comment, I didn't understand correctly.

Sorry, ignore my previous comment, I didn't understand correctly.
lx requested changes 2023-05-09 09:15:01 +00:00
src/block/manager.rs Outdated
@ -604,2 +609,4 @@
}
if fs::metadata(&path).await.is_ok() {
return Ok(true);
lx commented 2023-05-09 09:14:36 +00:00
Owner
Copy Link

The true/false values returned also need to be swapped in the case we are checking the non-compressed file first.

The true/false values returned also need to be swapped in the case we are checking the non-compressed file first.
jpds marked this conversation as resolved
jpds force-pushed skip-compressed-blocks-scrub-no-compression from 94470d5668 to 9899801472 2023-05-09 09:27:41 +00:00 Compare
jpds force-pushed skip-compressed-blocks-scrub-no-compression from 9899801472 to 9c788059e2 2023-05-09 09:28:32 +00:00 Compare
lx commented 2023-05-09 09:32:10 +00:00
Owner
Copy Link

LGTM

LGTM
lx merged commit 2f495575d8 into main 2023-05-09 09:39:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lx
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#566
No description provided.
Delete Branch "jpds/garage:skip-compressed-blocks-scrub-no-compression"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?