Deuxfleurs
/
garage
43
37
Fork 55
Code Issues 69 Pull Requests 4 Releases 29 Wiki Activity

K2V: double urlencoding #574

Merged
lx merged 2 commits from fix-k2v-urlencoding into main 2023-05-18 09:33:04 +00:00
Conversation 0 Commits 2 Files Changed 6 +63 -9
lx commented 2023-05-17 22:09:44 +00:00
Owner
Copy Link

This is a proposal fix for #573. Since rusoto_signature double-urlencodes paths for all APIs except S3, then we will do the same when verifying signatures client-side. This page suggest that path segments must indeed be url-encoded twice (once by http, once by the signature calculation algorithm): https://docs.aws.amazon.com/rolesanywhere/latest/userguide/authentication-sign-process.html

EDIT: wrote an extensive comment in the source code with more explanation, go read that.

Fix #573

This is a proposal fix for #573. Since rusoto_signature double-urlencodes paths for all APIs except S3, then we will do the same when verifying signatures client-side. This page suggest that path segments must indeed be url-encoded twice (once by http, once by the signature calculation algorithm): https://docs.aws.amazon.com/rolesanywhere/latest/userguide/authentication-sign-process.html EDIT: wrote an extensive comment in the source code with more explanation, go read that. Fix #573
lx force-pushed fix-k2v-urlencoding from de39da1103 to 92fdeb1c56 2023-05-18 09:17:21 +00:00 Compare
lx force-pushed fix-k2v-urlencoding from 92fdeb1c56 to 4420db7310 2023-05-18 09:18:27 +00:00 Compare
lx merged commit 03efc191c1 into main 2023-05-18 09:33:04 +00:00
lx deleted branch fix-k2v-urlencoding 2023-05-18 09:33:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AdminAPI

Issues concerning the administration API

  
Bug

   
Check AWS

The behaviour should be checked against AWS S3

  
CI

Issues with Nix, Drone, Rust Compiler, etc.

  
Correctness

Issues of theoretical correctness that may impact edge-case scenarios

  
Critical

   
Documentation

   
Ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  
Improvement

   
Low priority

For issues that we don't want to spend time on until made absolutely necessary

  
Newcomer

A bug that should be newcomer friendly.

  
Performance

   
S3 Compatibility

   
Testing

   
Usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

No Label
AdminAPI
Bug
Check AWS
CI
Correctness
Critical
Documentation
Ideas
Improvement
Low priority
Newcomer
Performance
S3 Compatibility
Testing
Usability
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#574
No description provided.
Delete Branch "fix-k2v-urlencoding"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?