Multipart uploads fail when the key contains an & (ampersand) #59

New issue

Closed

opened 2021-04-27 17:21:48 +00:00 by quentin · 0 comments

quentin commented

2021-04-27 17:21:48 +00:00

Owner

How to reproduce the bug

Create a file big enough to trigger a multipart upload.

dd if=/dev/urandom of=a.bin bs=1M count=129

Try to upload it in a key containing an ampersand.

mc cp 'a.bin' 'garage/quentin.bibliotheque/&'

What we obtain

mc: <ERROR> Failed to copy `a.bin`. XML syntax error on line 4: invalid character entity & (no semicolon)

What we expect

The same result than the one we have with non-multipart uploads:

dd if=/dev/urandom of=a.bin bs=1k count=129
mc cp 'a.bin' 'garage/quentin.bibliotheque/&'

Which gives us a successful upload

$ mc cp 'a.bin' 'garage/quentin.bibliotheque/&'
a.bin:                    129.00 KiB / 129.00 KiB
[==============================================================] 160.20 KiB/s 0s
$ mc ls 'garage/quentin.bibliotheque/&'
[2021-04-27 19:19:55 CEST] 129KiB &

Investigations

I did not have time to investigate the bug but I suspect that the bug is due to how we template XML files. I will try to investigate soon.

## How to reproduce the bug Create a file big enough to trigger a multipart upload. ```bash dd if=/dev/urandom of=a.bin bs=1M count=129 ``` Try to upload it in a key containing an ampersand. ```bash mc cp 'a.bin' 'garage/quentin.bibliotheque/&' ``` ## What we obtain ``` mc: <ERROR> Failed to copy `a.bin`. XML syntax error on line 4: invalid character entity & (no semicolon) ``` ## What we expect The same result than the one we have with non-multipart uploads: ```bash dd if=/dev/urandom of=a.bin bs=1k count=129 mc cp 'a.bin' 'garage/quentin.bibliotheque/&' ``` Which gives us a successful upload ``` $ mc cp 'a.bin' 'garage/quentin.bibliotheque/&' a.bin: 129.00 KiB / 129.00 KiB [==============================================================] 160.20 KiB/s 0s $ mc ls 'garage/quentin.bibliotheque/&' [2021-04-27 19:19:55 CEST] 129KiB & ``` ## Investigations I did not have time to investigate the bug but I suspect that the bug is due to how we template XML files. I will try to investigate soon.