Deuxfleurs/garage

Fork 73

Missing Allow Origin Headers #609

New issue

Closed

opened 2023-08-06 16:37:38 +00:00 by RndUsername · 3 comments

RndUsername commented

2023-08-06 16:37:38 +00:00

My CORS rules set via AWS CLI are:

> aws s3api get-bucket-cors --bucket home-dms-bucket
{
    "CORSRules": [
        {
            "AllowedHeaders": [
                "*"
            ],
            "AllowedMethods": [
                "POST"
            ],
            "AllowedOrigins": [
                "*"
            ],
            "MaxAgeSeconds": 3000
        }
    ]
}

And the response I get for the pre-flight OPTIONS is:

HTTP/1.1 200 OK
access-control-allow-origin: *
access-control-allow-methods: POST
access-control-allow-headers: *
access-control-expose-headers: 
content-length: 0
date: Mon, 31 Jul 2023 11:24:58 GMT

But for the POST request which gets called right after that, is:

HTTP/1.1 204 No Content
location: https://localhost:3900/home-dms-bucketclkqs9rq300038jj0ksji37iw
etag: "be91b057ab2b3e393e822ef0453eddc4"
date: Mon, 31 Jul 2023 11:24:58 GMT

Am I missing somthing? Does this happen to anyone else? I would really appreciate any help.

Hi, I posted my problem already on #258 and will reapeat it here in hope to get an answer faster: I get a 'CORS Missing Allow Origin' error on my POST requests but paradoxically not for my OPTIONS requests, so: OPTIONS ✅ POST ❌ 'CORS Missing Allow Origin' My CORS rules set via AWS CLI are: ``` > aws s3api get-bucket-cors --bucket home-dms-bucket { "CORSRules": [ { "AllowedHeaders": [ "*" ], "AllowedMethods": [ "POST" ], "AllowedOrigins": [ "*" ], "MaxAgeSeconds": 3000 } ] } ``` And the response I get for the pre-flight OPTIONS is: ``` HTTP/1.1 200 OK access-control-allow-origin: * access-control-allow-methods: POST access-control-allow-headers: * access-control-expose-headers: content-length: 0 date: Mon, 31 Jul 2023 11:24:58 GMT ``` But for the POST request which gets called right after that, is: ``` HTTP/1.1 204 No Content location: https://localhost:3900/home-dms-bucketclkqs9rq300038jj0ksji37iw etag: "be91b057ab2b3e393e822ef0453eddc4" date: Mon, 31 Jul 2023 11:24:58 GMT ``` Am I missing somthing? Does this happen to anyone else? I would really appreciate any help.

👍 1

RndUsername commented

2023-08-06 17:24:36 +00:00

Author

Soo... the images are actually getting uploaded fine but the browser still says its missing an allow origin header. So I can actually use garage as normal but I will get annoying error messages.

lx added the

kind

wrong-behavior

label 2023-10-16 09:39:21 +00:00

lx added this to the v1.0 milestone 2023-10-16 09:39:24 +00:00

jgourinda commented

2023-10-19 21:11:59 +00:00

Having the same issue using a presigned post URL. The response from garage is missing CORS headers

By the way thank you for the great product. Offering a great alternative.

Having the same issue using a presigned post URL. The response from garage is missing CORS headers By the way thank you for the great product. Offering a great alternative.

lx referenced this issue from a commit

2023-10-20 08:29:32 +00:00

s3 api: add missing CORS headers to PostObject responses (fix #609)

lx referenced this issue from a pull request that will close it,

2023-10-20 08:29:50 +00:00

s3 api: add missing CORS headers to PostObject responses (fix #609) #656

lx referenced this issue from a commit

2023-10-20 08:32:51 +00:00

s3 api: add missing CORS headers to PostObject responses (fix #609)

lx referenced this issue from a commit

2023-10-20 08:37:56 +00:00

s3 api: add missing CORS headers to PostObject responses (fix #609)

lx commented

2023-10-20 11:58:06 +00:00

Owner

Could you check that the issue is solved with the following builds?

Garage 0.8.x -> build ac04934daefe48ac4f41d22b9129d1fe2ce44833

Garage 0.9.x -> build 79eeb4f8d6bbe40274b48ff9c7c1bcc13dbdb714

Those builds can be found on the downloads page in the "development builds" section.

Could you check that the issue is solved with the following builds? Garage 0.8.x -> build `ac04934daefe48ac4f41d22b9129d1fe2ce44833` Garage 0.9.x -> build `79eeb4f8d6bbe40274b48ff9c7c1bcc13dbdb714` Those builds can be found on the downloads page in the "development builds" section.

lx closed this issue

2023-10-26 09:17:15 +00:00

lx referenced this issue from a commit

2023-10-26 09:17:15 +00:00

Merge pull request 's3 api: add missing CORS headers to PostObject responses (fix #609)' (#656) from fix-cors-post-object into main-0.8.x

lx referenced this issue from a commit

2024-01-16 11:13:07 +00:00

Garage v0.8.5