object lifecycles (fix #309) #620

Merged

lx merged 25 commits from bucket-lifecycle into next 2023-09-04 09:45:11 +00:00

Conversation 0 Commits 25 Files changed 14 +945 -53

lx commented 2023-08-29 15:03:17 +00:00

Owner

Copy link

This PR tracks the progress of NLnet task 2 (release garage v0.9), subtask 1 (implement object lifecycles).

• Add data model to bucket table for lifecycle configuration
• Implement S3 API calls to put, get and delete a bucket's lifecycle configuration
• Implement a worker that scans all objects at midnight UTC to apply the configuration
• Optimize the object scan to skip buckets with no lifecycle config
• Proof-reading
• Testing

This PR tracks the progress of NLnet task 2 (release garage v0.9), subtask 1 (implement object lifecycles). - [x] Add data model to bucket table for lifecycle configuration - [x] Implement S3 API calls to put, get and delete a bucket's lifecycle configuration - [x] Implement a worker that scans all objects at midnight UTC to apply the configuration - [x] Optimize the object scan to skip buckets with no lifecycle config - [x] Proof-reading - [x] Testing

lx added 1 commit 2023-08-29 15:03:18 +00:00

bucket_table: data model for lifecycle configuration 0b83e0558e

lx added this to the v0.9 milestone 2023-08-29 15:03:55 +00:00

lx referenced this pull request 2023-08-29 15:04:31 +00:00

Garage v0.9 #473

lx added 1 commit 2023-08-29 15:44:41 +00:00

s3: add xml structures to serialize/deserialize lifecycle configs 8041d9a827

lx added 1 commit 2023-08-29 16:22:19 +00:00

lifecycle: implement validation into garage's internal data structure abf011c290

lx added 1 commit 2023-08-30 09:24:33 +00:00

use a NaiveDate in data model, it serializes to string (iso 8601 format) f7b409f114

lx added 1 commit 2023-08-30 10:41:24 +00:00

lifecycle: skeleton for lifecycle worker a2e0e34db5

lx added 1 commit 2023-08-30 12:29:18 +00:00

lifecycle worker: implement main functionality 2996dc875f

lx added 2 commits 2023-08-30 12:51:20 +00:00

lifecycle worker: skip entire bucket when no lifecycle config is set da8b224e24

lifecycle worker: launch with the rest of Garage 0f1849e1ac

lx added 1 commit 2023-08-30 12:55:01 +00:00

lifecycle worker: add logging 7200954318

lx added 1 commit 2023-08-30 18:02:23 +00:00

lifecycle config: store date as given, try to debug 75ccc5a95c

lx added 1 commit 2023-08-30 18:06:05 +00:00

lifecycle config: add missing line in merge() and remove tracing d2e94e36d6

lx added 1 commit 2023-08-30 18:07:27 +00:00

bucket_table: bucketparams::new doesn't need to be pub a1d57283c0

lx added 1 commit 2023-08-30 21:24:40 +00:00

reference manual: document support for lifecycle configuration 5c923d48d7

lx added 1 commit 2023-08-30 21:27:18 +00:00

reference manual: remove obsolete caveat about multipart uploads d94f1c9178

lx added 1 commit 2023-08-30 21:39:49 +00:00

s3 bucket apis: remove redundant call f0a395e2e5

lx added 1 commit 2023-08-30 21:46:28 +00:00

lifecycle worker: avoid building chrono's serde feature 01c327a07a

lx added 1 commit 2023-08-30 21:47:49 +00:00

update cargo.nix 5fad4c4658

lx added 1 commit 2023-08-30 21:52:21 +00:00

lifecycle worker: take into account disabled rules b2f679675e

lx added 1 commit 2023-08-30 22:00:37 +00:00

s3api: remove redundant serde rename attribute be03a4610f

lx added 1 commit 2023-08-30 22:28:50 +00:00

lifecycle worker: mitigate potential bugs + refactoring 1cfcc61de8

lx added 1 commit 2023-08-31 09:19:41 +00:00

lifecycle worker: use queue_insert and process objects in batches adbf5925de

lx added 1 commit 2023-08-31 09:25:26 +00:00

lifecycle worker: add log message when starting a00a52633f

lx added 1 commit 2023-08-31 09:30:06 +00:00

lifecycle worker: fix potential inifinite loop f579d6d9b4

lx added 1 commit 2023-08-31 09:36:44 +00:00

lifecycle worker: don't get stuck on non-existent bucket 1cdc321e28

lx force-pushed bucket-lifecycle from 4bdd73e974 to 8e0c020bb9 2023-09-04 09:33:50 +00:00 Compare

lx changed title from WIP: object lifecycles (fix #309) to object lifecycles (fix #309) 2023-09-04 09:34:09 +00:00

lx changed title from object lifecycles (fix #309) to object lifecycles (fix #309) 2023-09-04 09:34:09 +00:00

lx merged commit 3f461d8891 into next 2023-09-04 09:45:11 +00:00

lx referenced this pull request from a commit 2023-09-04 09:45:11 +00:00

Merge pull request 'object lifecycles (fix #309)' (#620) from bucket-lifecycle into next

lx deleted branch bucket-lifecycle 2023-09-04 09:45:11 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

action

check-aws

The behaviour should be checked against AWS S3

  

action

discussion-needed

We need to discuss if the feature is desirable and/or better specify the envisioned behavior or technical implementation

  

action

for-external-contributors

Core team does not plan working on this in the near future however an external contribution will be reviewed & merged

  

action

for-newcomers

An issue that should be newcomer friendly.

  

action

more-info-needed

More information is needed to investigate this issue

  

action

need-funding

This issue represents lots of work, we need to find money to pay our core team work

  

action

triage-required

It's not very clear what we want to do with this issue yet, more thoughts is required

  

kind

correctness

Issues of theoretical correctness that may impact edge-case scenarios

  

kind

ideas

For abstract ideas/proposal to make Garage better, to better communicate our not yet achieved aims

  

kind

improvement

Feature requests that do not fall in other categories

  

kind

performance

Deceptive performance observed OR idea to improve performances

  

kind

testing

Functional tests, integration tests, Jepsen, etc.

  

kind

usability

Propositions to make Garage easier to operate, by improving error reporting, CLI, etc.

  

kind

wrong-behavior

Unintended behavior

  

prio

critical

Could impact integrity or availability of production clusters

  

prio

low

For issues that we don't want to spend time on until made absolutely necessary

  

scope

admin-api

Issues concerning the administration API

  

scope

background-healing

Background healing covers repair tasks, anti-entropy, merkle trees, etc. ; everything related to replicating data appropriately.

  

scope

build

Issues with Nix, Drone, Rust Compiler, etc.

  

scope

documentation

  

scope

k8s

Kubernetes related, including Helm Charts

  

scope

layout

Linked to the cluster layout and storage management

  

scope

metadata

Metadata Engine (LMDB, sqlite, etc.)

  

scope

ops

Operations related to operations/maintenance issue, tooling related (like CLI missing info ; impossible, too dangerous, too complicated migration, etc.)

  

scope

rpc

Linked to RPC

  

scope

s3-api

Related to the S3 API (especially compatibility issues).

  

scope

security

Cryptography-related, auth-related, authorization-related issues

  

scope

telemetry

OpenTelemetry (traces, metrics, etc.)

No labels

action

check-aws

action

discussion-needed

action

for-external-contributors

action

for-newcomers

action

more-info-needed

action

need-funding

action

triage-required

kind

correctness

kind

ideas

kind

improvement

kind

performance

kind

testing

kind

usability

kind

wrong-behavior

prio

critical

prio

low

scope

admin-api

scope

background-healing

scope

build

scope

documentation

scope

k8s

scope

layout

scope

metadata

scope

ops

scope

rpc

scope

s3-api

scope

security

scope

telemetry

Milestone

Clear milestone

No items

No milestone

v0.9

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Deuxfleurs/garage#620

No description provided.